Make job pod ImagePullPolicy configurable

The same need we had for adjusting the job pod and GHA action container's resources we also have for setting the imagePullPolicy.
element-hq · Mar 27, 2023 · dbedc2e · dbedc2e
1 parent cb50f5f
commit dbedc2e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/packages/k8s/src/hooks/prepare-job.ts b/packages/k8s/src/hooks/prepare-job.ts
@@ -167,6 +167,7 @@ export function createContainerSpec(
   const limit_memory = process.env.ACTIONS_POD_RESOURCE_LIMIT_MEMORY
   const request_memory = process.env.ACTIONS_POD_RESOURCE_REQUEST_MEMORY
   const request_cpu = process.env.ACTIONS_POD_RESOURCE_REQUEST_CPU
+  const imagePullPolicy = process.env.ACTIONS_POD_IMAGE_PULL_POLICY
   resources.requests = {
     ...(request_cpu != undefined) && {cpu: request_cpu},
     ...(request_memory != undefined) && {memory: request_memory},
@@ -178,6 +179,7 @@ export function createContainerSpec(
   const podContainer = {
     name,
     image: container.image,
+    imagePullPolicy: imagePullPolicy ? imagePullPolicy : "Always",
     ports: containerPorts(container),
     resources: resources
   } as k8s.V1Container

diff --git a/packages/k8s/src/hooks/run-container-step.ts b/packages/k8s/src/hooks/run-container-step.ts
@@ -85,6 +85,7 @@ function createPodSpec(
   const limit_memory = process.env.ACTIONS_POD_RESOURCE_LIMIT_MEMORY
   const request_memory = process.env.ACTIONS_POD_RESOURCE_REQUEST_MEMORY
   const request_cpu = process.env.ACTIONS_POD_RESOURCE_REQUEST_CPU
+  const imagePullPolicy = process.env.ACTIONS_POD_IMAGE_PULL_POLICY
   resources.requests = {
     ...(request_cpu != undefined) && {cpu: request_cpu},
     ...(request_memory != undefined) && {memory: request_memory},
@@ -96,6 +97,7 @@ function createPodSpec(
   podContainer.name = JOB_CONTAINER_NAME
   podContainer.image = container.image
   podContainer.resources = resources
+  podContainer.imagePullPolicy = imagePullPolicy ? imagePullPolicy : "Always"
 
   const { entryPoint, entryPointArgs } = container
   container.entryPoint = 'sh'