Foundation of new syn2mas tool #3636
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandhose
reviewed
Dec 9, 2024
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
e7172d6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://765d99cc.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://rei-syn2mas-pr1.matrix-authentication-service-docs.pages.dev |
reivilibre
force-pushed
the
rei/syn2mas_pr1
branch
from
fb1d512 to
64f5c65
Compare
sandhose
reviewed
Dec 11, 2024
sandhose
approved these changes
Dec 13, 2024
| } | ||
|
|
||
| pub struct SynapseReader<'c> { | ||
| conn: &'c mut PgConnection, |
There was a problem hiding this comment.
This point is still valid as you're already borrowing the connection here, but I'm fine leaving it like that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the start of a new version of the syn2mas tool.
Given it's missing a lot of stuff still, I'm intending to merge this to an intermediary branch where I can then build upon this with the missing features.
Notable inclusions
Notable missing features (for later PRs)
Performance
This currently runs a synthetic matrix.org-size migration under 15 seconds. (Bear in mind this is only one part of the migration, but it gives a rough idea of where we're going with this.)
The synthetic database was set up with the same number of real users as matrix.org, but guest and appservice users were not populated in the database so in reality this may run slower because the Synapse Postgres instance will need to read and skip rows corresponding to guests and appservice users.