Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the RustSDK to v25.01.15 and fix (most) concurrency sendability warnings in the generated mocks #3680

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu added the pr-misc for other changes label Jan 15, 2025
@stefanceriu stefanceriu requested a review from a team as a code owner January 15, 2025 10:33
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team January 15, 2025 10:33
Copy link

github-actions bot commented Jan 15, 2025

Warnings
⚠️ Please provide a description for this PR.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 4b9ef3d

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.48%. Comparing base (e3ad925) to head (4b9ef3d).
Report is 2 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3680      +/-   ##
===========================================
- Coverage    78.52%   78.48%   -0.04%     
===========================================
  Files          792      792              
  Lines        67338    67338              
===========================================
- Hits         52875    52849      -26     
- Misses       14463    14489      +26     
Flag Coverage Δ
unittests 69.98% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@BillCarsonFr BillCarsonFr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me

@stefanceriu stefanceriu merged commit c29175d into develop Jan 15, 2025
13 checks passed
@stefanceriu stefanceriu deleted the stefan/sdkBump branch January 15, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants