Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the overlapping scrollbars on the room list filters on macOS. #3646

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Dec 20, 2024

This PR makes 2 changes:

  • Fix the filters scroll view content so that if isn't clipped on the leading edge and has matching padding on the trailing edge
  • Add some extra padding to the content on macOS so that any scroll bars don't overlap (the padding is then removed from the view itself so no extra space is take up). Fixes Horizontal Scrollbar overlays filters on macOS #2583
Before iPhone After iPhone
before iphone after iphone
Mouse macOS No mouse macOS
mouse macOS no mouse macOS

@pixlwave pixlwave requested a review from a team as a code owner December 20, 2024 13:24
@pixlwave pixlwave requested review from stefanceriu and removed request for a team December 20, 2024 13:24
@pixlwave pixlwave added the pr-bugfix for bug fix label Dec 20, 2024
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo! 👏

Copy link

codecov bot commented Dec 20, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
908 1 907 0
View the full list of 1 ❄️ flaky tests
PreviewTests test_userProfileScreen()

Flake rate in main: 9.52% (Passed 38 times, Failed 4 times)

Stack Traces | 3.72s run time
failed - Snapshot "Verified User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_userProfileScreen-iPhone-16-pseudo.Verified-User.png"
@+
"file:.../tmp/PreviewTests/test_userProfileScreen-iPhone-16-pseudo.Verified-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.892395 is less than required 1.0
The lowest perceptual color precision 0.31062502 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:84)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@pixlwave pixlwave merged commit b8106f3 into develop Dec 20, 2024
10 checks passed
@pixlwave pixlwave deleted the doug/mac-scrollbar branch December 20, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Horizontal Scrollbar overlays filters on macOS
2 participants