Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design tweaks. #3645

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Design tweaks. #3645

merged 2 commits into from
Dec 20, 2024

Conversation

pixlwave
Copy link
Member

This PR makes 2 changes:

@pixlwave pixlwave requested a review from a team as a code owner December 20, 2024 12:28
@pixlwave pixlwave requested review from Velin92 and removed request for a team December 20, 2024 12:28
Copy link

github-actions bot commented Dec 20, 2024

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against c7b877f

Copy link

codecov bot commented Dec 20, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
908 1 907 0
View the full list of 1 ❄️ flaky tests
PreviewTests test_roomMemberDetailsScreen()

Flake rate in main: 10.17% (Passed 106 times, Failed 12 times)

Stack Traces | 1.91s run time
failed - Snapshot "Ignored User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-pseudo.Ignored-User.png"
@+
"file:.../tmp/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-pseudo.Ignored-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.90600586 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:85)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, 🚀 it!

@stefanceriu stefanceriu added the pr-change for updates to an existing feature label Dec 20, 2024
@pixlwave pixlwave merged commit 885a5b9 into develop Dec 20, 2024
8 checks passed
@pixlwave pixlwave deleted the doug/design-tweaks branch December 20, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Update the design of the recovery key field
2 participants