Security and privacy part 2 #3637
Draft
+1,392
−155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Velin92
added
the
pr-wip
Generated by 🚫 Danger Swift against 6e84f51 |
|
❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format. |
visibility state
added also the preview tests
and improved handling of the access -> vsibility reaction. Also added a simple error handling for the public directory toggle
but is missing its full implementation
stefanceriu
reviewed
Dec 20, 2024
Comment on lines
-45
to
+64
| let encryptionBinding = Binding<Bool>(get: { | ||
| let binding = Binding<Bool>(get: { |
There was a problem hiding this comment.
What was wrong with encryptionBinding? 😅
There was a problem hiding this comment.
well it was a local variable in the scope, and the only binding so I thought having it named binding, was fine.
ElementX/Sources/Screens/SecurityAndPrivacyScreen/SecurityAndPrivacyScreenViewModel.swift
Outdated
Show resolved
Hide resolved
| if let canonicalAlias = roomProxy.infoPublisher.value.canonicalAlias { | ||
| aliasLocalPart = canonicalAlias.dropFirst().split(separator: ":").first.flatMap(String.init) ?? "" | ||
| } else if let displayName = roomProxy.infoPublisher.value.displayName { | ||
| aliasLocalPart = roomAliasNameFromRoomDisplayName(roomName: displayName) |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, requires some SDK API that are still in review
What is left to do: