-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Element Call: display error dialog only when loading the main URL #3962
Element Call: display error dialog only when loading the main URL #3962
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3962 +/- ##
===========================================
- Coverage 83.07% 83.06% -0.01%
===========================================
Files 1791 1791
Lines 45348 45351 +3
Branches 5350 5353 +3
===========================================
Hits 37673 37673
- Misses 5799 5802 +3
Partials 1876 1876 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK for the change, but we should probably give more info in the onError
lambda and let the presenter decide what to do.
Also there is another call to onError
in onReceivedSslError
, maybe also protect this call hence I do not think it is necessary to fix the issue.
0b3ce8e
to
20192eb
Compare
20192eb
to
76f16e1
Compare
Quality Gate passedIssues Measures |
Content
Only propagate 'webview errors' to display the error dialog when the errors happen while trying to load the webview's main URL. At the moment this happened when trying to load any asset or external URL too.
Motivation and context
Fix #3896.
Note this may not work properly on URL redirections, although I hope a redirection means the webview's URL has changed and the check is still valid. In any case, it would be a rare corner case.
Tests
Tested devices
Checklist