Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide confirm message as not needed at point of sign in #6934

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

hughns
Copy link
Member

@hughns hughns commented Oct 19, 2022

Pull Request Checklist

  • I read the contributing guide
  • UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • Accessibility has been taken into account.
  • Pull request is based on the develop branch
  • Pull request contains a changelog file in ./changelog.d
  • You've made a self review of your PR
  • Pull request includes screenshots or videos of UI changes
  • Pull request includes a sign off

@stefanceriu stefanceriu self-requested a review October 19, 2022 11:42
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Attention: Patch coverage is 0% with 40 lines in your changes missing coverage. Please review.

Project coverage is 6.14%. Comparing base (6b27303) to head (0ab35f2).
Report is 2405 commits behind head on develop.

Files with missing lines Patch % Lines
...ogin/Common/Service/MatrixSDK/QRLoginService.swift 0.00% 26 Missing ⚠️
...firm/View/AuthenticationQRLoginConfirmScreen.swift 0.00% 11 Missing ⚠️
...ailure/AuthenticationQRLoginFailureViewModel.swift 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6934       +/-   ##
============================================
- Coverage    54.86%    6.14%   -48.72%     
============================================
  Files          423     1590     +1167     
  Lines        16607   156613   +140006     
  Branches      6743    63196    +56453     
============================================
+ Hits          9111     9627      +516     
- Misses        7288   146558   +139270     
- Partials       208      428      +220     
Flag Coverage Δ
unittests 6.14% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants