Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unsend messages, not working for failed messages. showing the unsend message delete/retry button for ever. #6334

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

toshanmugaraj
Copy link
Contributor

@toshanmugaraj toshanmugaraj commented Jun 23, 2022

Pull Request Checklist

  • I read the contributing guide
  • UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • Accessibility has been taken into account.
  • Pull request is based on the develop branch
  • Pull request contains a changelog file in ./changelog.d
  • You've made a self review of your PR
  • Pull request includes screenshots or videos of UI changes
  • Pull request includes a sign off

@toshanmugaraj toshanmugaraj changed the title Delete unsend messages, not refreshing the view. Delete unsend messages, not working for failed messages. showing the unsend message delete/retry button for ever. Jun 23, 2022
@pixlwave
Copy link
Member

pixlwave commented Jun 23, 2022

Hi @toshanmugaraj thanks for opening this PR. Please would you be able to provide a bit of context about the bug that this fixes (and how to reproduce it) for me to review the code? Also, we'll need a changelog file in ./changelog.d and a sign off in order to be able to merge this.

Signed-off-by: Shunmugaraj S [email protected]
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (develop@835cdda). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #6334   +/-   ##
==========================================
  Coverage           ?    6.17%           
==========================================
  Files              ?     1440           
  Lines              ?   155102           
  Branches           ?    62360           
==========================================
  Hits               ?     9585           
  Misses             ?   145113           
  Partials           ?      404           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 835cdda...e340a57. Read the comment docs.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants