Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create triage-labelled.yml #1295

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Create triage-labelled.yml #1295

merged 3 commits into from
Nov 6, 2023

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Oct 27, 2023 •
edited by github-actions bot
Loading

This calls the triage-labelled workflow from element-web so that we get the same label automation in both repositories.

Needs: element-hq/element-web#26509

This change is marked as an internal change (Task), so will not be included in the changelog.

@Johennes
Create triage-labelled.yml
51dda63 
This copies https://github.com/vector-im/element-web/blob/develop/.github/workflows/triage-labelled.yml as I believe we want the same label automation in both repositories.
@Johennes Johennes added the T-Task Tasks for the team like planning label Oct 27, 2023
@Johennes Johennes requested a review from a team as a code owner October 27, 2023 14:24
@Johennes Johennes requested a review from t3chguy October 27, 2023 14:24
t3chguy
t3chguy requested changes Oct 27, 2023
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please use reusable workflows instead of having to remember to update multiple identical workflows

@Johennes Johennes mentioned this pull request Nov 6, 2023
Merged
@Johennes
Copy link
Contributor Author

Johennes commented Nov 6, 2023

Can we please use reusable workflows instead of having to remember to update multiple identical workflows

Good shout. Have made it so (hopefully correctly). See also element-hq/element-web#26509.

@Johennes Johennes enabled auto-merge November 6, 2023 13:17
@Johennes Johennes merged commit cb3cb91 into develop Nov 6, 2023
24 checks passed
@Johennes Johennes deleted the Johennes-patch-1 branch November 6, 2023 13:56
@Johennes
Copy link
Contributor Author

Johennes commented Nov 6, 2023

Looks like this hasn't worked: https://github.com/vector-im/element-desktop/actions/runs/6772073606/job/18403835946

The GitHub token appears to be missing.

@Johennes
Copy link
Contributor Author

Johennes commented Nov 6, 2023

Which is odd given that the docs say

The called workflow is automatically granted access to github.token and secrets.GITHUB_TOKEN.

@t3chguy
Copy link
Member

t3chguy commented Nov 6, 2023 •
edited
Loading

@Johennes yes but that action is using ELEMENT_BOT_TOKEN so you need to wire secrets through..

https://github.com/vector-im/element-web/blob/develop/.github/workflows/triage-labelled.yml#L140

@Johennes
Copy link
Contributor Author

Johennes commented Nov 6, 2023

Argh, ok yeah I see it now 🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Johennes @t3chguy