Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add developer mode option to show RTC connection statistics #2904

Open
wants to merge 8 commits into
base: livekit
Choose a base branch
from

Conversation

hughns
Copy link
Member

@hughns hughns commented Dec 16, 2024

New option in developer settings:

image

Which overlays some basic info on audio and video when available:

image

And you can click to get the full RTCInboundRtpStreamStats | RTCOutboundRtpStreamStats data in a modal:

image

@hughns hughns force-pushed the hughns/connection-stats branch from b2aeeb8 to 6f4d5a7 Compare December 16, 2024 17:09
@hughns hughns marked this pull request as ready for review December 16, 2024 17:11
@toger5
Copy link
Contributor

toger5 commented Dec 16, 2024

This introduces some odd horizontal scrolling on Firefox:
image

@toger5
Copy link
Contributor

toger5 commented Dec 16, 2024

Could be the tooltip provider?

@hughns
Copy link
Member Author

hughns commented Dec 17, 2024

This introduces some odd horizontal scrolling on Firefox:

Good spot. It's the same on Chrome too.

@hughns
Copy link
Member Author

hughns commented Dec 18, 2024

I've moved the detailed data into a modal and I think it's probably good enough for now.

@hughns hughns requested a review from toger5 December 18, 2024 17:30
Copy link
Contributor

@toger5 toger5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is hard to tell how much time and effort we want to put into this.
There are a couple of issues:
your own stream does not show reasonable data:
image

The styling is hard to read, the buttons are super small.
But I suspect this is just debug information and should not be used by users who want EC to be pretty.
I will give it a quick try to change the css to be a bit more fitting and you can check if you like it.

@toger5
Copy link
Contributor

toger5 commented Dec 19, 2024

Here are the proposed changes: #2916

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants