Force using the latest version of the WASM bindings #2903
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandhose
force-pushed
the
quenting/better-wasm-loading
branch
from
3a28533 to
0414978
Compare
sandhose
changed the title
sandhose
force-pushed
the
quenting/better-wasm-loading
branch
from
0414978 to
b6036d0
Compare
hughns
reviewed
Dec 17, 2024
There was a problem hiding this comment.
Whilst this appears to "just work", I think we should wait until matrix-org/matrix-js-sdk#4589 is approved (or a least that they don't identify some issues that need to be worked through.
|
The upstream PR has been merged. So this PR is superseded by #2911 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should mean the WASM blob is finally shipped as WASM, and not a JS string! It massively helps with page load time