Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify settings tabs #2875

Merged
merged 8 commits into from
Dec 11, 2024
Merged

Simplify settings tabs #2875

merged 8 commits into from
Dec 11, 2024

Conversation

hughns
Copy link
Member

@hughns hughns commented Dec 6, 2024

  • Move Analytics to Feedback tab
  • Rename Developer Settings to Developer Mode and move to Preferences tab
  • Clean up Preferences tab
  • Only way to see version number is by enabling Developer Mode
  • Remove More tab

Before:
image
image
image

After:
image
image

@hughns
Simplify settings tabs
d233ff4 
- Move Analytics to Feedback tab
- Rename Developer Settings to Developer Mode and move to Preferences tab
- Clean up Preferences tab
- Only way to see version number is by enabling Developer Mode
@hughns hughns added X-Needs-Design May require input from the design team X-Needs-Product More input needed from the Product team labels Dec 6, 2024
@fkwp
Copy link
Contributor

fkwp commented Dec 9, 2024

fine for me

@fkwp fkwp removed the X-Needs-Product More input needed from the Product team label Dec 9, 2024
@hughns hughns marked this pull request as ready for review December 9, 2024 14:57
@hughns hughns requested a review from a team as a code owner December 9, 2024 14:57
@hughns hughns requested a review from toger5 December 9, 2024 14:57
@americanrefugee
Copy link

LGTM

@hughns hughns removed the X-Needs-Design May require input from the design team label Dec 9, 2024
robintown
robintown approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Timo's suggestion aside (I don't feel strongly about it)

locales/en/app.json Outdated Show resolved Hide resolved
@hughns hughns enabled auto-merge (squash) December 11, 2024 09:21
@hughns hughns merged commit 54149a4 into livekit Dec 11, 2024
5 checks passed
@hughns hughns mentioned this pull request Dec 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robintown robintown robintown approved these changes

@toger5 toger5 Awaiting requested review from toger5 toger5 is a code owner automatically assigned from element-hq/element-call-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hughns @fkwp @americanrefugee @toger5 @robintown