Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for generic reactions #2708

Merged
merged 125 commits into from
Nov 8, 2024
Merged

Support for generic reactions #2708

merged 125 commits into from
Nov 8, 2024

Conversation

Half-Shot
Copy link
Member

@Half-Shot Half-Shot commented Nov 1, 2024 •
edited
Loading

Requires element-hq/compound-design-tokens#116 for the icon

This is the PoC for the generic-emoji-reactions feature. Currently you can:

  • Send a reaction to a call via a new picker
  • Play a specific sound for that reaction (or a generic sound otherwise).
  • Incorporates the raise hand button into the same menu for space conservation.
  • Enable/disable sounds/animations from the preferences menu.

TODO:

  • Add tests.
  • Appropriately specify licenses for sound effects.

image

mgcm and others added 30 commits September 19, 2024 11:35
@mgcm
Initial support for Hand Raise feature
48cf487 
Signed-off-by: Milton Moura <[email protected]>
@mgcm
Refactored to use reaction and redaction events
2d1917c 
Signed-off-by: Milton Moura <[email protected]>
@mgcm
Replacing button svg with raised hand emoji
f6ae6a0 
Signed-off-by: Milton Moura <[email protected]>
@mgcm
SpotlightTile should not duplicate the raised hand
ac7321d 
Signed-off-by: Milton Moura <[email protected]>
@fkwp @mgcm
Update src/room/useRaisedHands.tsx
bcad500 
Element Call recently changed to AGPL-3.0
@mgcm
Use relations to load existing reactions when joining the call
0730ba5 
Signed-off-by: Milton Moura <[email protected]>
@mgcm
Links to sha commit of matrix-js-sdk that exposes the call membership…
ab5654c 
… event id and refactors some async code

Signed-off-by: Milton Moura <[email protected]>
@mgcm
Removing RaiseHand.svg
7ac5642
@mgcm
Check for reaction & redaction capabilities in widget mode
69a50fb 
Signed-off-by: Milton Moura <[email protected]>
@mgcm
Fix failing GridTile test
42a7b1e 
Signed-off-by: Milton Moura <[email protected]>
@Half-Shot
Center align hand raise.
16afb56
@Half-Shot
Add support for displaying the duration of a raised hand.
1c8e547
@Half-Shot
Add a sound for when a hand is raised.
7f268a3
@Half-Shot
Refactor raised hand indicator and add tests.
a23d256
@Half-Shot
lint
43b4fc0
@Half-Shot
Refactor into own files.
4501e67
@Half-Shot
Redact the right thing.
4a712dc
@Half-Shot
Tidy up useEffect
ba921f8
@Half-Shot
Lint tests
9d01e8c
@Half-Shot
Remove extra layer
38878d3
@Half-Shot
Add better sound. (woosh)
33724ef
@Half-Shot
Add a small mode for spotlight
198859d
@Half-Shot
Fix timestamp calculation on relaod.
07d3451
@Half-Shot
Fix call border resizing video
b7e8236
@Half-Shot
lint
23d849b
@Half-Shot
Fix and update tests
f13bd79
@Half-Shot
Allow timer to be configurable.
dbabf45
@Half-Shot
Add preferences tab for choosing to enable timer.
e1a4310
@Half-Shot
Drop border from raised hand icon
0b6cf18
@Half-Shot
Handle cases when a new member event happens.
528e692
@Half-Shot Half-Shot requested a review from robintown November 8, 2024 13:39
robintown
robintown reviewed Nov 8, 2024
View reviewed changes
src/button/ReactionToggleButton.tsx Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/useReactions.tsx Outdated Show resolved Hide resolved
@Half-Shot Half-Shot requested a review from robintown November 8, 2024 16:21
@Half-Shot Half-Shot merged commit 5d88c52 into livekit Nov 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkwp fkwp fkwp left review comments

@anoadragon453 anoadragon453 anoadragon453 left review comments

@robintown robintown robintown approved these changes

@toger5 toger5 toger5 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Half-Shot @anoadragon453 @fkwp @toger5 @robintown @mgcm