Don't use event.sender #1722
Merged
Don't use event.sender #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull in a js-sdk change to avoid using event.sender (see js-sdk PR for details). Fixes #1697
dbkr
added
the
T-Defect
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## livekit #1722 +/- ##
========================================
Coverage 30.01% 30.01%
========================================
Files 47 47
Lines 1876 1876
Branches 327 327
========================================
Hits 563 563
Misses 1271 1271
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
toger5
approved these changes
Oct 10, 2023
toger5
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull in a js-sdk change to avoid using event.sender (see js-sdk PR for details).
Fixes #1697
Requires matrix-org/matrix-js-sdk#3793