-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Fix microphone loss during background voice calls on Android 14 #8914
[Bugfix] Fix microphone loss during background voice calls on Android 14 #8914
Conversation
@bmarty It is very important to check this as soon as possible and release a new version of the application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
Only one remark at first sight.
Also, can you add a sign off to the PR please, so I can merge it?
android:foregroundServiceType="microphone" | ||
android:permission="android.permission.FOREGROUND_SERVICE_MICROPHONE"> | ||
</service> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to declare the permission as well. You can add around line 56:
<!-- For MicrophoneAccessService -->
<uses-permission android:name="android.permission.FOREGROUND_SERVICE_MICROPHONE" />
It is working since this permission comes with the Jitsi library, but better to explicitely add it in our manifest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did it and pushed, tell me if there is any more comments of improvement that need to be done :)
|
…ne usage in calls. Signed-off-by: AmitShilo <[email protected]>
fc05d99
to
53387e6
Compare
Signed-off-by: AmitShilo <[email protected]>
@bmarty Will this fix make it into the next release? |
Signed-off-by: AmitShilo <[email protected]>
i fixed one bug that i found, it was a crash when getting incoming call from lock screen. |
@bmarty Is this fix planned? |
Hello, I'm taking the liberty of relaunching the ticket because this problem renders the application useless (voice calls without voice are useless even if you know sign language). The criticality level is maximum. Do you need help to get things moving? Best regards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update!
Implemented a microphone access service to ensure uninterrupted microphone usage during voice calls, even when the app is running in the background.
Left photo represent when the call is in the background, and right when the app is open (no change in this case).
Type of change
Content
This pull request fixes a bug where the app loses microphone access when it goes into the background during a voice call. The issue has been resolved by ensuring that microphone access is maintained during background operations and that the microphone service continues running as needed.
Motivation and context
Issue: App loses microphone access when not active on v 1.6.20 #8881
Steps to reproduce:
Expected outcome:
The conversation should continue without interruptions, and the app should maintain access to the microphone even when switching to other apps or locking the phone.
Actual outcome:
The other party cannot hear the user because the app loses access to the microphone, which is indicated by the disappearance of the green dot on Samsung S24 devices.
Operating system: Android 14
App version: Element 1.6.20 (Google Play Store)
Screenshots / GIFs
Tests
Tested devices
Checklist