Skip to content

Commit

Permalink
Merge pull request #8790 from element-hq/feature/bma/externalAnalytic…
Browse files Browse the repository at this point in the history
…sPlan

Add dependency on `com.github.matrix-org:matrix-analytics-events`
  • Loading branch information
bmarty authored May 16, 2024
2 parents 085bf82 + 6e1b346 commit f9a8451
Show file tree
Hide file tree
Showing 29 changed files with 5 additions and 2,684 deletions.
24 changes: 0 additions & 24 deletions .github/workflows/sync-from-external-sources.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,27 +58,3 @@ jobs:
- Update SAS Strings from matrix-doc.
branch: sync-sas-strings
base: develop

sync-analytics-plan:
runs-on: ubuntu-latest
# Skip in forks
if: github.repository == 'element-hq/element-android'
# No concurrency required, runs every time on a schedule.
steps:
- uses: actions/checkout@v3
- name: Run analytics import script
run: ./tools/import_analytic_plan.sh
- name: Create Pull Request for analytics plan
uses: peter-evans/create-pull-request@v5
with:
commit-message: Sync analytics plan
title: Sync analytics plan
body: |
### Update analytics plan
Reviewers:
- [ ] Please remove usage of Event or Enum which may have been removed or updated
- [ ] please ensure new Events or new Enums are used to send analytics by pushing new commit(s) to this PR.
*Note*: Change are coming from [this project](https://github.com/matrix-org/matrix-analytics-events)
branch: sync-analytics-plan
base: develop
1 change: 1 addition & 0 deletions dependencies_groups.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ ext.groups = [
'com.github.hyuwah',
'com.github.jetradarmobile',
'com.github.MatrixFrog',
'com.github.matrix-org',
'com.github.tapadoo',
'com.github.UnifiedPush',
'com.github.yalantis',
Expand Down
2 changes: 1 addition & 1 deletion docs/analytics.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ We ask for the user to give consent before sending any analytics data.

The analytics plan is shared between all Element clients. To add an Event, please open a PR to this project: https://github.com/matrix-org/matrix-analytics-events

Then, once the PR has been merged, you can run the tool `import_analytic_plan.sh` to import the plan to Element, and then you can use the new Event. Note that this tool is run by Github action once a week.
Then, once the PR has been merged, and the library is release, you can update the version of the library in the `build.gradle` file.

## Forks of Element

Expand Down
18 changes: 0 additions & 18 deletions tools/import_analytic_plan.sh

This file was deleted.

3 changes: 3 additions & 0 deletions vector/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,9 @@ dependencies {
// Debug
api 'com.facebook.stetho:stetho:1.6.0'

// Analytics
api 'com.github.matrix-org:matrix-analytics-events:0.15.0'

api libs.google.phonenumber

// FlowBinding
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading

0 comments on commit f9a8451

Please sign in to comment.