Merge pull request #8928 from element-hq/feature/bma/java21

Java 21
element-hq · Nov 12, 2024 · ac94bff · ac94bff
2 parents 21e751e + 6d7e744
commit ac94bff
Show file tree

Hide file tree

Showing 10 changed files with 29 additions and 25 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -28,11 +28,11 @@ jobs:
         with:
           # https://github.com/actions/checkout/issues/881
           ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
-      - name: Use JDK 17
+      - name: Use JDK 21
         uses: actions/setup-java@v4
         with:
           distribution: 'temurin' # See 'Supported distributions' for available options
-          java-version: '17'
+          java-version: '21'
       - name: Configure gradle
         uses: gradle/actions/setup-gradle@v3
         with:
@@ -57,11 +57,11 @@ jobs:
         with:
           # https://github.com/actions/checkout/issues/881
           ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.ref }}
-      - name: Use JDK 17
+      - name: Use JDK 21
         uses: actions/setup-java@v4
         with:
           distribution: 'temurin' # See 'Supported distributions' for available options
-          java-version: '17'
+          java-version: '21'
       - name: Configure gradle
         uses: gradle/actions/setup-gradle@v3
         with:

diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml
@@ -20,11 +20,11 @@ jobs:
         uses: actions/setup-python@v4
         with:
           python-version: 3.8
-      - name: Use JDK 17
+      - name: Use JDK 21
         uses: actions/setup-java@v4
         with:
           distribution: 'temurin' # See 'Supported distributions' for available options
-          java-version: '17'
+          java-version: '21'
       - name: Configure gradle
         uses: gradle/actions/setup-gradle@v3
         with:

diff --git a/.github/workflows/post-pr.yml b/.github/workflows/post-pr.yml
@@ -44,11 +44,11 @@ jobs:
         uses: actions/setup-python@v4
         with:
           python-version: 3.8
-      - name: Use JDK 17
+      - name: Use JDK 21
         uses: actions/setup-java@v4
         with:
           distribution: 'temurin' # See 'Supported distributions' for available options
-          java-version: '17'
+          java-version: '21'
       - name: Configure gradle
         uses: gradle/actions/setup-gradle@v3
         with:

diff --git a/.github/workflows/quality.yml b/.github/workflows/quality.yml
@@ -25,11 +25,11 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - name: Use JDK 17
+      - name: Use JDK 21
         uses: actions/setup-java@v4
         with:
           distribution: 'temurin' # See 'Supported distributions' for available options
-          java-version: '17'
+          java-version: '21'
       - name: Configure gradle
         uses: gradle/actions/setup-gradle@v3
         with:
@@ -48,11 +48,11 @@ jobs:
       cancel-in-progress: true
     steps:
       - uses: actions/checkout@v4
-      - name: Use JDK 17
+      - name: Use JDK 21
         uses: actions/setup-java@v4
         with:
           distribution: 'temurin' # See 'Supported distributions' for available options
-          java-version: '17'
+          java-version: '21'
       - name: Configure gradle
         uses: gradle/actions/setup-gradle@v3
         with:
@@ -102,11 +102,11 @@ jobs:
       cancel-in-progress: true
     steps:
       - uses: actions/checkout@v4
-      - name: Use JDK 17
+      - name: Use JDK 21
         uses: actions/setup-java@v4
         with:
           distribution: 'temurin' # See 'Supported distributions' for available options
-          java-version: '17'
+          java-version: '21'
       - name: Configure gradle
         uses: gradle/actions/setup-gradle@v3
         with:

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -29,11 +29,11 @@ jobs:
         with:
           lfs: true
           fetch-depth: 0
-      - name: Use JDK 17
+      - name: Use JDK 21
         uses: actions/setup-java@v4
         with:
           distribution: 'temurin' # See 'Supported distributions' for available options
-          java-version: '17'
+          java-version: '21'
       - name: Configure gradle
         uses: gradle/actions/setup-gradle@v3
         with:
@@ -139,11 +139,11 @@ jobs:
 #      cancel-in-progress: true
 #    steps:
 #      - uses: actions/checkout@v4
-#      - name: Use JDK 17
+#      - name: Use JDK 21
 #        uses: actions/setup-java@v4
 #        with:
 #          distribution: 'temurin' # See 'Supported distributions' for available options
-#          java-version: '17'
+#          java-version: '21'
 #      - name: Configure gradle
 #        uses: gradle/actions/setup-gradle@v3
 #        with:

diff --git a/build.gradle b/build.gradle
@@ -43,7 +43,7 @@ plugins {
     // ktlint Plugin
     id "org.jlleitschuh.gradle.ktlint" version "11.3.2"
     // Detekt
-    id "io.gitlab.arturbosch.detekt" version "1.22.0"
+    id "io.gitlab.arturbosch.detekt" version "1.23.7"
     // Ksp
     id "com.google.devtools.ksp" version "1.9.24-1.0.20"
 

diff --git a/dependencies.gradle b/dependencies.gradle
@@ -2,9 +2,9 @@ ext.versions = [
         'minSdk'            : 21,
         'compileSdk'        : 34,
         'targetSdk'         : 34,
-        'sourceCompat'      : JavaVersion.VERSION_17,
-        'targetCompat'      : JavaVersion.VERSION_17,
-        'jvmTarget'         : "17",
+        'sourceCompat'      : JavaVersion.VERSION_21,
+        'targetCompat'      : JavaVersion.VERSION_21,
+        'jvmTarget'         : "21",
 ]
 
 def gradle = "8.4.2"

diff --git a/dependencies_groups.gradle b/dependencies_groups.gradle
@@ -203,6 +203,7 @@ ext.groups = [
                         'org.jacoco',
                         'org.java-websocket',
                         'org.jcodec',
+                        'org.jcommander',
                         'org.jetbrains',
                         'org.jetbrains.dokka',
                         'org.jetbrains.intellij.deps',
@@ -229,6 +230,7 @@ ext.groups = [
                         'org.reactivestreams',
                         'org.robolectric',
                         'org.slf4j',
+                        'org.snakeyaml',
                         'org.sonatype.oss',
                         'org.testng',
                         'org.threeten',

diff --git a/library/external/textdrawable/build.gradle b/library/external/textdrawable/build.gradle
@@ -1,7 +1,5 @@
 apply plugin: 'com.android.library'
 
-apply plugin: 'com.android.library'
-
 android {
     namespace "com.amulyakhare.textdrawable"
 

diff --git a/tools/detekt/detekt.yml b/tools/detekt/detekt.yml
@@ -25,6 +25,8 @@ style:
     active: false
   UseCheckOrError:
     active: false
+  UnusedPrivateProperty:
+    active: false
 
 empty-blocks:
   EmptyFunctionBlock:
@@ -75,6 +77,8 @@ naming:
 performance:
   SpreadOperator:
     active: false
+  ForEachOnRange:
+    active: false
 
 # Note: all rules for `comments` are disabled by default, but I put them here to be aware of their existence
 comments:
@@ -91,7 +95,7 @@ comments:
   EndOfSentenceFormat:
     active: true
   OutdatedDocumentation:
-    active: true
+    active: false
   UndocumentedPublicClass:
     active: false
   UndocumentedPublicFunction: