Create toggle menu item component #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robintown
requested review from
kerryarchibald and
weeman1337
and removed request for
a team
This is a pretty common way for the menu item component to be used, and it's slightly non-trivial (you need to hook up the entire menu item as a label element), so I think it deserves its own component.
Deploying with
|
| Latest commit: |
afbf3e1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://969eb27b.compound-web.pages.dev |
| Branch Preview URL: | https://toggle-menu-item.compound-web.pages.dev |
robintown
force-pushed
the
toggle-menu-item
branch
from
5caa813 to
29534f6
Compare
robintown
commented
Sep 26, 2023
germain-gg
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty common way for the menu item component to be used, and it's slightly non-trivial (you need to hook up the entire menu item as a label element), so I think it deserves its own component.
Latest designs