Ponyfill useId #88
Merged
Ponyfill useId #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johennes
requested review from
dbkr and
kerryarchibald
and removed request for
a team
Closed
Deploying with
|
| Latest commit: |
7898f19
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f1defd41.compound-web.pages.dev |
| Branch Preview URL: | https://johannes-pony-fill-use-id.compound-web.pages.dev |
Johennes
requested review from
germain-gg
and removed request for
dbkr and
kerryarchibald
|
Percy is now failing because of the quota.
|
t3chguy
approved these changes
Sep 26, 2023
germain-gg
reviewed
Sep 26, 2023
There was a problem hiding this comment.
Code looks good to me,
Could we add an ESLint rule to make useId a restricted import and suggest using your ponyfill instead?
I believe we're using https://eslint.org/docs/latest/rules/no-restricted-imports on EW
Does not have to block this pull request, but a quick follow up would be appreciated
|
Ok, let me see if I can get that going tonight. Will land this in the interim. |
|
Sorry, I didn't get around to do this last night. I have put in element-hq/compound#228 and will try to come back to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by https://github.com/ezcater/recipe/blob/dc253df74f0b9c509f13172980eb8c1a0defb62a/packages/recipe/src/utils/hooks/useUniqueId.ts.
Fixes: element-hq/compound#224
Replaces: #85