Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep the version of playwright and ubuntu in sync between GHA and Docker #297

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

sandhose
Copy link
Member

This sets explicit versions in the GHA workflow and in the Dockerfile, adding a note that they should be kept in sync.
All the snapshot diffs are from upgrading from Ubuntu 22.04 to Ubuntu 24.04.

@sandhose sandhose requested a review from a team as a code owner December 13, 2024 08:32
@sandhose sandhose requested review from dbkr and robintown and removed request for a team December 13, 2024 08:32
Copy link

cloudflare-workers-and-pages bot commented Dec 13, 2024

Deploying compound-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: 578970d
Status: ✅  Deploy successful!
Preview URL: https://9dd9e193.compound-web.pages.dev
Branch Preview URL: https://quenting-sync-playwright-doc.compound-web.pages.dev

View logs

Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might also be able to tell renovate to create PRs for both of these together.

@sandhose sandhose merged commit d73fba6 into main Dec 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants