Add style package export for dist/style.css
#125
Conversation
kerryarchibald
requested review from
andybalaam and
dbkr
and removed request for
a team
Deploying with
|
| Latest commit: |
263e7d4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://70993fac.compound-web.pages.dev |
| Branch Preview URL: | https://kerry-styles-export.compound-web.pages.dev |
There was a problem hiding this comment.
In wasn't aware of this but looks like it's a thing that webpack reads (https://webpack.js.org/guides/package-exports/#conditions)? Looks fine. What happened if the style export wasn't set? It failed rather than falling back to one of the others?
Yep, when the specific type is not specified it will result in module not found:
|
package.json
Outdated
| @@ -13,7 +13,8 @@ | |||
| }, | |||
| "./dist/style.css": { | |||
| "require": "./dist/style.css", | |||
| "import": "./dist/style.css" | |||
| "import": "./dist/style.css", | |||
| "style": "./dist/style.css" | |||
There was a problem hiding this comment.
Wouldn't it make sense then to set it in the . import? I think that would make @import "@vector-im/compound-web" work?
There was a problem hiding this comment.
Oh good idea!
The following syntax will set the style condition: