Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alert component tweaks #121

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Alert component tweaks #121

merged 3 commits into from
Oct 31, 2023

Conversation

kerryarchibald
Copy link
Contributor

For element-hq/compound#250

  • Changed: Set description text to font.body.sm.regular
  • Added: New variant with a stacked layout. Actions on the bottom.
  • Added: New variant with a 2 column layout. Actions on the right column, vertically centered. It should shift to stacked layout when the component width (container query) is below 600px.
  • Bug: The corner radius should be 8px.
  • Bug: The close/dismiss button is not correctly sized.

Not adding new variants in this change.

Figma — Alert Component

@kerryarchibald kerryarchibald requested a review from a team as a code owner October 31, 2023 02:54
@kerryarchibald kerryarchibald requested review from germain-gg and dbkr and removed request for a team October 31, 2023 02:54
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 31, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4f9ad34
Status: ✅  Deploy successful!
Preview URL: https://f84be8cb.compound-web.pages.dev
Branch Preview URL: https://kerry-250-alert-component-fi.compound-web.pages.dev

View logs

germain-gg
germain-gg approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@kerryarchibald kerryarchibald merged commit 4edbed2 into main Oct 31, 2023
6 of 7 checks passed
@kerryarchibald kerryarchibald deleted the kerry/250/alert-component-fixes branch October 31, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@germain-gg germain-gg germain-gg approved these changes

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from element-hq/compound-web-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kerryarchibald @germain-gg