Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a colour token in light mode on the SendButton. #131

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Dec 5, 2024

Use light/icon/on-solid-primary instead of dark/icon/primary in light mode. This also removes the need to override the colour scheme now seeing as the gradient isn't using reactive colours either.

It's hard to see but there is a difference to the light mode compared to #130:

test_sendButton-iPhone-16 1

@pixlwave pixlwave requested a review from a team as a code owner December 5, 2024 16:28
@pixlwave pixlwave requested review from stefanceriu and removed request for a team December 5, 2024 16:28
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.65%. Comparing base (78e1290) to head (cc26ed8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #131   +/-   ##
=======================================
  Coverage   96.65%   96.65%           
=======================================
  Files          22       22           
  Lines        1374     1374           
=======================================
  Hits         1328     1328           
  Misses         46       46           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pixlwave pixlwave merged commit 7ebf9db into main Dec 6, 2024
3 checks passed
@pixlwave pixlwave deleted the doug/send-button-light-fg branch December 6, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants