New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap icons with a forwardRef #92

Merged

sandhose merged 1 commit into main from quenting/icons-forward-ref

Jul 17, 2024

Member

sandhose commented Jul 15, 2024

@robintown I saw in element-hq/compound-web#208 that you tried to forward references to the icons, but we didn't forwardRef when rendering them.

This wraps all the icons with a forwardRef. The most annoying part of this is the typing, because forwardRef has a pretty exotic type signature.


          Wrap icons with a forwardRef

3470f3a

sandhose mentioned this pull request

Allow setting a ref on InlineSpinner element-hq/compound-web#208

Merged

sandhose requested a review from robintown

July 16, 2024 07:38

robintown approved these changes

View reviewed changes

Member

robintown left a comment

Thanks, I blindly trusted the types 😅

sandhose merged commit 87aae09 into main

3 checks passed

sandhose deleted the quenting/icons-forward-ref branch

July 17, 2024 06:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet