Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mark-threads-as-read icon. #107

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Add mark-threads-as-read icon. #107

merged 1 commit into from
Aug 20, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Aug 15, 2024

Adds the mark-threads-as-read icon and runs yarn build

@robintown help! It seems we're not generating the icons for Swift/Kotlin anymore 🙈
Ignore me! not sure what happened, I see all the changes now.

@pixlwave pixlwave requested a review from a team as a code owner August 15, 2024 10:10
@pixlwave
Copy link
Member Author

Ah ok, so it looks like when you add a new icon, running yarn build only updates icons/* and assets/web/icons/*. You have to run it a second time to update assets/android/*, assets/ios/* and assets/web/js/*

@pixlwave pixlwave requested a review from robintown August 15, 2024 10:16
@pixlwave pixlwave merged commit 5fbec43 into main Aug 20, 2024
3 checks passed
@pixlwave pixlwave deleted the doug/icons branch August 20, 2024 08:43
@pixlwave
Copy link
Member Author

Merged and I've moved the discussion about asset generation into element-hq/compound#326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants