Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will change the default encoding strategies of
Date
,Data
andURL
objects, since they can be stored directly in Dictionaries unlike JSON, which does not support those types directly and thus defaults to formatted/base64String
s.String
, but toNSData
directlyString
andNSData
objectDate
directly, if no other strategy is chosenDate
objects directlyString
s anymore, but toNSURL
directlyString
s andNSURL
sAlso, following test was not passing before, since a base64 encoded
String
was expected forData
objects.This PR will also cleanup and add some more tests.