Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add ts-node checks and optional peer dependency #3709

Closed
wants to merge 1 commit into from

Conversation

rtritto
Copy link

@rtritto rtritto commented Sep 20, 2024

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
rechoir dependency use ts-node if forge.config file is a TypeScript file (forge.config.ts) so ts-node needs to be installed as dependency.
Add an error message if ts-node dependency is missing.

Fix #3609

@rtritto rtritto requested a review from a team as a code owner September 20, 2024 11:43
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s reserve dependency changes to maintainers, please

@erickzhao erickzhao closed this Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing ts-node and esbuild-register as optional peer dependencies
3 participants