feat(publisher-gcs): only include provided upload options #3576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickzhao
reviewed
May 2, 2024
| @@ -23,24 +23,26 @@ export default class PublisherGCS extends PublisherStatic<PublisherGCSConfig> { | |||
| async publish({ makeResults, setStatusLine }: PublisherOptions): Promise<void> { | |||
| const artifacts: GCSArtifact[] = []; | |||
|
|
|||
| if (!this.config.bucket) { | |||
| const { storageOptions, bucket: configBucket, folder, ...uploadOptions } = this.config; | |||
There was a problem hiding this comment.
question: I haven't tested this locally yet but we do have a custom keyResolver property in the Config as well that would get rolled up with ...uploadOptions. Would passing in that unknown key into bucket.upload trigger an error on the GCS SDK side?
There was a problem hiding this comment.
I haven't had any trouble with it, and it doesn't look like there's any checking for extraneous keys in their library. That could change, of course.
We could also pull out keyResolver here if you think it's a concern
georgexu99
approved these changes
Sep 19, 2024
erickzhao
approved these changes
Sep 19, 2024
erickzhao
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Brooooooklyn
referenced
this pull request
in toeverything/AFFiNE
Sep 24, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | Type | Update | |---|---|---|---|---|---|---|---| | [@electron-forge/cli](https://redirect.github.com/electron/forge) | [`7.4.0` -> `7.5.0`](https://renovatebot.com/diffs/npm/@electron-forge%2fcli/7.4.0/7.5.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | minor | | [@electron-forge/core](https://redirect.github.com/electron/forge) | [`7.4.0` -> `7.5.0`](https://renovatebot.com/diffs/npm/@electron-forge%2fcore/7.4.0/7.5.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | minor | | [@electron-forge/core-utils](https://redirect.github.com/electron/forge) | [`7.4.0` -> `7.5.0`](https://renovatebot.com/diffs/npm/@electron-forge%2fcore-utils/7.4.0/7.5.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | minor | | [@electron-forge/maker-base](https://redirect.github.com/electron/forge) | [`7.4.0` -> `7.5.0`](https://renovatebot.com/diffs/npm/@electron-forge%2fmaker-base/7.4.0/7.5.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | resolutions | minor | | [@electron-forge/maker-deb](https://redirect.github.com/electron/forge) | [`7.4.0` -> `7.5.0`](https://renovatebot.com/diffs/npm/@electron-forge%2fmaker-deb/7.4.0/7.5.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | minor | | [@electron-forge/maker-dmg](https://redirect.github.com/electron/forge) | [`7.4.0` -> `7.5.0`](https://renovatebot.com/diffs/npm/@electron-forge%2fmaker-dmg/7.4.0/7.5.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | minor | | [@electron-forge/maker-squirrel](https://redirect.github.com/electron/forge) | [`7.4.0` -> `7.5.0`](https://renovatebot.com/diffs/npm/@electron-forge%2fmaker-squirrel/7.4.0/7.5.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | minor | | [@electron-forge/maker-zip](https://redirect.github.com/electron/forge) | [`7.4.0` -> `7.5.0`](https://renovatebot.com/diffs/npm/@electron-forge%2fmaker-zip/7.4.0/7.5.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | minor | | [@electron-forge/plugin-auto-unpack-natives](https://redirect.github.com/electron/forge) | [`7.4.0` -> `7.5.0`](https://renovatebot.com/diffs/npm/@electron-forge%2fplugin-auto-unpack-natives/7.4.0/7.5.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | minor | | [@electron-forge/shared-types](https://redirect.github.com/electron/forge) | [`7.4.0` -> `7.5.0`](https://renovatebot.com/diffs/npm/@electron-forge%2fshared-types/7.4.0/7.5.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | minor | | [@fal-ai/serverless-client](https://redirect.github.com/fal-ai/fal-js) ([source](https://redirect.github.com/fal-ai/fal-js/tree/HEAD/libs/client)) | [`0.14.2` -> `0.14.3`](https://renovatebot.com/diffs/npm/@fal-ai%2fserverless-client/0.14.2/0.14.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | dependencies | patch | | [@playwright/test](https://playwright.dev) ([source](https://redirect.github.com/microsoft/playwright)) | [`=1.47.1` -> `=1.47.2`](https://renovatebot.com/diffs/npm/@playwright%2ftest/1.47.1/1.47.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | [@sentry/react](https://redirect.github.com/getsentry/sentry-javascript/tree/master/packages/react) ([source](https://redirect.github.com/getsentry/sentry-javascript)) | [`8.30.0` -> `8.31.0`](https://renovatebot.com/diffs/npm/@sentry%2freact/8.30.0/8.31.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | dependencies | minor | | [@sentry/react](https://redirect.github.com/getsentry/sentry-javascript/tree/master/packages/react) ([source](https://redirect.github.com/getsentry/sentry-javascript)) | [`8.30.0` -> `8.31.0`](https://renovatebot.com/diffs/npm/@sentry%2freact/8.30.0/8.31.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | minor | | [@storybook/addon-essentials](https://redirect.github.com/storybookjs/storybook/tree/next/code/addons/essentials) ([source](https://redirect.github.com/storybookjs/storybook/tree/HEAD/code/addons/essentials)) | [`8.3.1` -> `8.3.2`](https://renovatebot.com/diffs/npm/@storybook%2faddon-essentials/8.3.1/8.3.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | [@storybook/addon-interactions](https://redirect.github.com/storybookjs/storybook/tree/next/code/addons/interactions) ([source](https://redirect.github.com/storybookjs/storybook/tree/HEAD/code/addons/interactions)) | [`8.3.1` -> `8.3.2`](https://renovatebot.com/diffs/npm/@storybook%2faddon-interactions/8.3.1/8.3.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | [@storybook/addon-links](https://redirect.github.com/storybookjs/storybook/tree/next/code/addons/links) ([source](https://redirect.github.com/storybookjs/storybook/tree/HEAD/code/addons/links)) | [`8.3.1` -> `8.3.2`](https://renovatebot.com/diffs/npm/@storybook%2faddon-links/8.3.1/8.3.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | [@storybook/addon-mdx-gfm](https://redirect.github.com/storybookjs/storybook/tree/next/code/addons/gfm) ([source](https://redirect.github.com/storybookjs/storybook/tree/HEAD/code/addons/gfm)) | [`8.3.1` -> `8.3.2`](https://renovatebot.com/diffs/npm/@storybook%2faddon-mdx-gfm/8.3.1/8.3.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | [@storybook/react](https://redirect.github.com/storybookjs/storybook/tree/next/code/renderers/react) ([source](https://redirect.github.com/storybookjs/storybook/tree/HEAD/code/renderers/react)) | [`8.3.1` -> `8.3.2`](https://renovatebot.com/diffs/npm/@storybook%2freact/8.3.1/8.3.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | [@storybook/react-vite](https://redirect.github.com/storybookjs/storybook/tree/next/code/frameworks/react-vite) ([source](https://redirect.github.com/storybookjs/storybook/tree/HEAD/code/frameworks/react-vite)) | [`8.3.1` -> `8.3.2`](https://renovatebot.com/diffs/npm/@storybook%2freact-vite/8.3.1/8.3.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | [@types/react](https://redirect.github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react) ([source](https://redirect.github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react)) | [`18.3.7` -> `18.3.8`](https://renovatebot.com/diffs/npm/@types%2freact/18.3.7/18.3.8) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | [electron](https://redirect.github.com/electron/electron) | [`32.1.1` -> `32.1.2`](https://renovatebot.com/diffs/npm/electron/32.1.1/32.1.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | [esbuild](https://redirect.github.com/evanw/esbuild) | [`^0.23.0` -> `^0.24.0`](https://renovatebot.com/diffs/npm/esbuild/0.23.1/0.24.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | minor | | [html-validate](https://html-validate.org) ([source](https://gitlab.com/html-validate/html-validate)) | [`8.22.0` -> `8.23.0`](https://renovatebot.com/diffs/npm/html-validate/8.22.0/8.23.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | dependencies | minor | | [jotai](https://redirect.github.com/pmndrs/jotai) | [`2.9.3` -> `2.10.0`](https://renovatebot.com/diffs/npm/jotai/2.9.3/2.10.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | dependencies | minor | | [keyv](https://redirect.github.com/jaredwray/keyv) | [`5.0.1` -> `5.0.3`](https://renovatebot.com/diffs/npm/keyv/5.0.1/5.0.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | dependencies | patch | | [lucide-react](https://lucide.dev) ([source](https://redirect.github.com/lucide-icons/lucide/tree/HEAD/packages/lucide-react)) | [`^0.441.0` -> `^0.445.0`](https://renovatebot.com/diffs/npm/lucide-react/0.441.0/0.445.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | dependencies | minor | | [msw](https://mswjs.io) ([source](https://redirect.github.com/mswjs/msw)) | [`2.4.8` -> `2.4.9`](https://renovatebot.com/diffs/npm/msw/2.4.8/2.4.9) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | [napi](https://redirect.github.com/napi-rs/napi-rs) | `3.0.0-alpha.9` -> `3.0.0-alpha.11` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | workspace.dependencies | patch | | [napi-derive](https://redirect.github.com/napi-rs/napi-rs) | `3.0.0-alpha.8` -> `3.0.0-alpha.11` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | workspace.dependencies | patch | | [nodemon](https://nodemon.io) ([source](https://redirect.github.com/remy/nodemon)) | [`3.1.5` -> `3.1.7`](https://renovatebot.com/diffs/npm/nodemon/3.1.5/3.1.7) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | [nx](https://nx.dev) ([source](https://redirect.github.com/nrwl/nx/tree/HEAD/packages/nx)) | [`19.7.4` -> `19.8.0`](https://renovatebot.com/diffs/npm/nx/19.7.4/19.8.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | minor | | [openai](https://redirect.github.com/openai/openai-node) | [`4.62.1` -> `4.63.0`](https://renovatebot.com/diffs/npm/openai/4.62.1/4.63.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | dependencies | minor | | [playwright](https://playwright.dev) ([source](https://redirect.github.com/microsoft/playwright)) | [`=1.47.1` -> `=1.47.2`](https://renovatebot.com/diffs/npm/playwright/1.47.1/1.47.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | [react-day-picker](https://daypicker.dev) ([source](https://redirect.github.com/gpbl/react-day-picker)) | [`9.1.0` -> `9.1.2`](https://renovatebot.com/diffs/npm/react-day-picker/9.1.0/9.1.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | dependencies | patch | | [socket.io](https://redirect.github.com/socketio/socket.io/tree/main/packages/socket.io#readme) ([source](https://redirect.github.com/socketio/socket.io)) | [`4.7.5` -> `4.8.0`](https://renovatebot.com/diffs/npm/socket.io/4.7.5/4.8.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | dependencies | minor | | [socket.io-client](https://redirect.github.com/socketio/socket.io/tree/main/packages/socket.io-client#readme) ([source](https://redirect.github.com/socketio/socket.io)) | [`4.7.5` -> `4.8.0`](https://renovatebot.com/diffs/npm/socket.io-client/4.7.5/4.8.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | dependencies | minor | | [storybook](https://redirect.github.com/storybookjs/storybook/tree/next/code/lib/cli) ([source](https://redirect.github.com/storybookjs/storybook/tree/HEAD/code/lib/cli)) | [`8.3.1` -> `8.3.2`](https://renovatebot.com/diffs/npm/storybook/8.3.1/8.3.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | [vite](https://vitejs.dev) ([source](https://redirect.github.com/vitejs/vite/tree/HEAD/packages/vite)) | [`5.4.6` -> `5.4.7`](https://renovatebot.com/diffs/npm/vite/5.4.6/5.4.7) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | [wrangler](https://redirect.github.com/cloudflare/workers-sdk) ([source](https://redirect.github.com/cloudflare/workers-sdk/tree/HEAD/packages/wrangler)) | [`3.78.5` -> `3.78.7`](https://renovatebot.com/diffs/npm/wrangler/3.78.5/3.78.7) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | --- ### Release Notes <details> <summary>electron/forge (@​electron-forge/cli)</summary> ### [`v7.5.0`](https://redirect.github.com/electron/forge/releases/tag/v7.5.0) [Compare Source](https://redirect.github.com/electron/forge/compare/v7.4.0...v7.5.0) ##### What's Changed ##### Improved ESM module support Electron Forge v7.5.0 adds support for loading Forge modules (plugins, makers, publishers etc.) that use ESM for their module format. This change allows both official Forge modules and third-party modules to use ESM syntax. ##### Change in Vite support policy v7.5.0 also makes refinements to our Vite plugin, fixing an issue that users identified as breaking between 7.2.0 and 7.3.0 ([https://github.com/electron/forge/issues/3506](https://redirect.github.com/electron/forge/issues/3506)). Users upgrading from any past version of Forge to 7.5.0 should now not experience breaking config changes. After discussion with maintainers, we've decided to retroactively mark the Vite plugin as **experimental**, as the plugin is still under active development and cannot offer the same API stability guarantees as our other existing plugins. Minor versions may include breaking changes to improve developer ergonomics or to fix bugs (especially around native Node.js modules). When these changes happen, we'll provide additional migration information in future release notes. - feat(plugin-vite): better logic by [@​caoxiemeihao](https://redirect.github.com/caoxiemeihao) in [https://github.com/electron/forge/pull/3583](https://redirect.github.com/electron/forge/pull/3583) - feat(core): support ESM Forge module loading by [@​SpacingBat3](https://redirect.github.com/SpacingBat3) in [https://github.com/electron/forge/pull/3582](https://redirect.github.com/electron/forge/pull/3582) - feat(core): adding register/unregisterForgeConfigForDirectory to utils by [@​IIIMADDINIII](https://redirect.github.com/IIIMADDINIII) in [https://github.com/electron/forge/pull/3626](https://redirect.github.com/electron/forge/pull/3626) - feat(publisher-gcs): only include provided upload options by [@​kochrt](https://redirect.github.com/kochrt) in [https://github.com/electron/forge/pull/3576](https://redirect.github.com/electron/forge/pull/3576) - feat: Adding optional metadata config to gcs publisher by [@​Tobiasartz](https://redirect.github.com/Tobiasartz) in [https://github.com/electron/forge/pull/3682](https://redirect.github.com/electron/forge/pull/3682) - feat(maker-wix): Expose the property associateExtensions by [@​fras2560](https://redirect.github.com/fras2560) in [https://github.com/electron/forge/pull/3674](https://redirect.github.com/electron/forge/pull/3674) - feat(plugin-webpack): support for dev server custom headers by [@​rahul-sachdeva22](https://redirect.github.com/rahul-sachdeva22) in [https://github.com/electron/forge/pull/3653](https://redirect.github.com/electron/forge/pull/3653) ##### Bug Fixes and Improvements - fix(cli): cli capitalisation by [@​DevanceJ](https://redirect.github.com/DevanceJ) in [https://github.com/electron/forge/pull/3539](https://redirect.github.com/electron/forge/pull/3539) - ci: don't use versionDocs option in API Documentation workflow by [@​dsanders11](https://redirect.github.com/dsanders11) in [https://github.com/electron/forge/pull/3571](https://redirect.github.com/electron/forge/pull/3571) - test(import): check if electron-quick-start packages by [@​erickzhao](https://redirect.github.com/erickzhao) in [https://github.com/electron/forge/pull/3580](https://redirect.github.com/electron/forge/pull/3580) - fix(maker-squirrel): only push `delta` artifacts if they exist on disk by [@​hipstersmoothie](https://redirect.github.com/hipstersmoothie) in [https://github.com/electron/forge/pull/3586](https://redirect.github.com/electron/forge/pull/3586) - docs: upgrade [email protected] by [@​erickzhao](https://redirect.github.com/erickzhao) in [https://github.com/electron/forge/pull/3636](https://redirect.github.com/electron/forge/pull/3636) - fix(plugin-webpack): protocol recognizes webpack's `devServer` setting by [@​Dogdriip](https://redirect.github.com/Dogdriip) in [https://github.com/electron/forge/pull/3650](https://redirect.github.com/electron/forge/pull/3650) - fix(hooks): allow mutating hooks to have a `void` return by [@​erickzhao](https://redirect.github.com/erickzhao) in [https://github.com/electron/forge/pull/3655](https://redirect.github.com/electron/forge/pull/3655) - fix: Bump [@​electron/packager](https://redirect.github.com/electron/packager) to ^18.3.5 by [@​felixrieseberg](https://redirect.github.com/felixrieseberg) in [https://github.com/electron/forge/pull/3692](https://redirect.github.com/electron/forge/pull/3692) - chore: bump electronjs/node to 2.3.0 (main) by [@​electron-roller](https://redirect.github.com/electron-roller) in [https://github.com/electron/forge/pull/3596](https://redirect.github.com/electron/forge/pull/3596) - chore(publisher-s3): update aws-sdk deps by [@​erickzhao](https://redirect.github.com/erickzhao) in [https://github.com/electron/forge/pull/3708](https://redirect.github.com/electron/forge/pull/3708) - chore: bump `asar` dep to latest by [@​erickzhao](https://redirect.github.com/erickzhao) in [https://github.com/electron/forge/pull/3592](https://redirect.github.com/electron/forge/pull/3592) - test: correctly make test-output.xml paths relative in windows by [@​yangannyx](https://redirect.github.com/yangannyx) in [https://github.com/electron/forge/pull/3620](https://redirect.github.com/electron/forge/pull/3620) - docs: mark plugin-vite as experimental by [@​VerteDinde](https://redirect.github.com/VerteDinde) in [https://github.com/electron/forge/pull/3710](https://redirect.github.com/electron/forge/pull/3710) ##### New Contributors - [@​DevanceJ](https://redirect.github.com/DevanceJ) made their first contribution in [https://github.com/electron/forge/pull/3539](https://redirect.github.com/electron/forge/pull/3539) - [@​hipstersmoothie](https://redirect.github.com/hipstersmoothie) made their first contribution in [https://github.com/electron/forge/pull/3586](https://redirect.github.com/electron/forge/pull/3586) - [@​Tobiasartz](https://redirect.github.com/Tobiasartz) made their first contribution in [https://github.com/electron/forge/pull/3682](https://redirect.github.com/electron/forge/pull/3682) - [@​rahul-sachdeva22](https://redirect.github.com/rahul-sachdeva22) made their first contribution in [https://github.com/electron/forge/pull/3653](https://redirect.github.com/electron/forge/pull/3653) - [@​fras2560](https://redirect.github.com/fras2560) made their first contribution in [https://github.com/electron/forge/pull/3674](https://redirect.github.com/electron/forge/pull/3674) - [@​IIIMADDINIII](https://redirect.github.com/IIIMADDINIII) made their first contribution in [https://github.com/electron/forge/pull/3626](https://redirect.github.com/electron/forge/pull/3626) - [@​SpacingBat3](https://redirect.github.com/SpacingBat3) made their first contribution in [https://github.com/electron/forge/pull/3582](https://redirect.github.com/electron/forge/pull/3582) - [@​kochrt](https://redirect.github.com/kochrt) made their first contribution in [https://github.com/electron/forge/pull/3576](https://redirect.github.com/electron/forge/pull/3576) **Full Changelog**: https://github.com/electron/forge/compare/v7.4.0...v7.5.0 </details> <details> <summary>fal-ai/fal-js (@​fal-ai/serverless-client)</summary> ### [`v0.14.3`](https://redirect.github.com/fal-ai/fal-js/compare/b3ab5f0e15d70d83c439f6a77bb3a5cfa7fa3271...762f28918ded71b9569d6a0d028fd5a486b5b80f) [Compare Source](https://redirect.github.com/fal-ai/fal-js/compare/b3ab5f0e15d70d83c439f6a77bb3a5cfa7fa3271...762f28918ded71b9569d6a0d028fd5a486b5b80f) </details> <details> <summary>microsoft/playwright (@​playwright/test)</summary> ### [`v1.47.2`](https://redirect.github.com/microsoft/playwright/releases/tag/v1.47.2) [Compare Source](https://redirect.github.com/microsoft/playwright/compare/v1.47.1...v1.47.2) ##### Highlights [https://github.com/microsoft/playwright/pull/32699](https://redirect.github.com/microsoft/playwright/pull/32699)- \[REGRESSION]: fix(codegen): use content_frame property in python/.NET[https://github.com/microsoft/playwright/issues/32706](https://redirect.github.com/microsoft/playwright/issues/32706)6- \[REGRESSION]: page.pause() does not pause test timeout after 1.4[https://github.com/microsoft/playwright/pull/32661](https://redirect.github.com/microsoft/playwright/pull/32661)61 - fix(trace-viewer): time delta between local and remote actions #### Browser Versions - Chromium 129.0.6668.29 - Mozilla Firefox 130.0 - WebKit 18.0 This version was also tested against the following stable channels: - Google Chrome 128 - Microsoft Edge 128 </details> <details> <summary>getsentry/sentry-javascript (@​sentry/react)</summary> ### [`v8.31.0`](https://redirect.github.com/getsentry/sentry-javascript/releases/tag/8.31.0) [Compare Source](https://redirect.github.com/getsentry/sentry-javascript/compare/8.30.0...8.31.0) ##### Important Changes - **feat(node): Add `dataloader` integration ([#​13664](https://redirect.github.com/getsentry/sentry-javascript/issues/13664))** This release adds a new integration for the [`dataloader` package](https://www.npmjs.com/package/dataloader). The Node SDK (and all SDKs that depend on it) will now automatically instrument `dataloader` instances. You can also add it manually: ```js Sentry.init({ integrations: [Sentry.dataloaderIntegration()], }); ``` ##### Other Changes - feat(browser): Add navigation `activationStart` timestamp to pageload span ([#​13658](https://redirect.github.com/getsentry/sentry-javascript/issues/13658)) - feat(gatsby): Add optional `deleteSourcemapsAfterUpload` ([#​13610](https://redirect.github.com/getsentry/sentry-javascript/issues/13610)) - feat(nextjs): Give app router prefetch requests a `http.server.prefetch` op ([#​13600](https://redirect.github.com/getsentry/sentry-javascript/issues/13600)) - feat(nextjs): Improve Next.js serverside span data quality ([#​13652](https://redirect.github.com/getsentry/sentry-javascript/issues/13652)) - feat(node): Add `disableInstrumentationWarnings` option ([#​13693](https://redirect.github.com/getsentry/sentry-javascript/issues/13693)) - feat(nuxt): Adding `experimental_basicServerTracing` option to Nuxt module ([#​13643](https://redirect.github.com/getsentry/sentry-javascript/issues/13643)) - feat(nuxt): Improve logs about adding Node option 'import' ([#​13726](https://redirect.github.com/getsentry/sentry-javascript/issues/13726)) - feat(replay): Add `onError` callback + other small improvements to debugging ([#​13721](https://redirect.github.com/getsentry/sentry-javascript/issues/13721)) - feat(replay): Add experimental option to allow for a checkout every 6 minutes ([#​13069](https://redirect.github.com/getsentry/sentry-javascript/issues/13069)) - feat(wasm): Unconditionally parse instruction addresses ([#​13655](https://redirect.github.com/getsentry/sentry-javascript/issues/13655)) - fix: Ensure all logs are wrapped with `consoleSandbox` ([#​13690](https://redirect.github.com/getsentry/sentry-javascript/issues/13690)) - fix(browser): Try multiple options for `lazyLoadIntegration` script parent element lookup ([#​13717](https://redirect.github.com/getsentry/sentry-javascript/issues/13717)) - fix(feedback): Actor color applies to feedback icon ([#​13702](https://redirect.github.com/getsentry/sentry-javascript/issues/13702)) - fix(feedback): Fix form width on mobile devices ([#​13068](https://redirect.github.com/getsentry/sentry-javascript/issues/13068)) - fix(nestjs): Preserve original function name on `SentryTraced` functions ([#​13684](https://redirect.github.com/getsentry/sentry-javascript/issues/13684)) - fix(node): Don't overwrite local variables for re-thrown errors ([#​13644](https://redirect.github.com/getsentry/sentry-javascript/issues/13644)) - fix(normalize): Treat Infinity as NaN both are non-serializable numbers ([#​13406](https://redirect.github.com/getsentry/sentry-javascript/issues/13406)) - fix(nuxt): Use correct server output file path ([#​13725](https://redirect.github.com/getsentry/sentry-javascript/issues/13725)) - fix(opentelemetry): Always use active span in `Propagator.inject` ([#​13381](https://redirect.github.com/getsentry/sentry-javascript/issues/13381)) - fix(replay): Fixes potential out-of-order segments ([#​13609](https://redirect.github.com/getsentry/sentry-javascript/issues/13609)) Work in this release was contributed by [@​KyGuy2002](https://redirect.github.com/KyGuy2002), [@​artzhookov](https://redirect.github.com/artzhookov), and [@​julianCast](https://redirect.github.com/julianCast). Thank you for your contributions! </details> <details> <summary>storybookjs/storybook (@​storybook/addon-essentials)</summary> ### [`v8.3.2`](https://redirect.github.com/storybookjs/storybook/blob/HEAD/CHANGELOG.md#832) [Compare Source](https://redirect.github.com/storybookjs/storybook/compare/v8.3.1...v8.3.2) - CLI: Fix skip-install for stable latest releases - [#​29133](https://redirect.github.com/storybookjs/storybook/pull/29133), thanks [@​valentinpalkovic](https://redirect.github.com/valentinpalkovic)! - Core: Do not add packageManager field to package.json during `storybook dev` - [#​29152](https://redirect.github.com/storybookjs/storybook/pull/29152), thanks [@​valentinpalkovic](https://redirect.github.com/valentinpalkovic)! </details> <details> <summary>electron/electron (electron)</summary> ### [`v32.1.2`](https://redirect.github.com/electron/electron/releases/tag/v32.1.2): electron v32.1.2 [Compare Source](https://redirect.github.com/electron/electron/compare/v32.1.1...v32.1.2) ### Release Notes for v32.1.2 #### Fixes - Fixed an issue where clicking the eyedropper icon did nothing instead of opening an eyedropper for color selection as expected. [#​43786](https://redirect.github.com/electron/electron/pull/43786) <span style="font-size:small;">(Also in [33](https://redirect.github.com/electron/electron/pull/43700))</span> - Third time isn't always a charm. Fixed the native macOS Screen Share picker invocation triggering a test Chromium green screen. [#​43809](https://redirect.github.com/electron/electron/pull/43809) <span style="font-size:small;">(Also in [33](https://redirect.github.com/electron/electron/pull/43810))</span> </details> <details> <summary>evanw/esbuild (esbuild)</summary> ### [`v0.24.0`](https://redirect.github.com/evanw/esbuild/blob/HEAD/CHANGELOG.md#0240) [Compare Source](https://redirect.github.com/evanw/esbuild/compare/v0.23.1...v0.24.0) ***This release deliberately contains backwards-incompatible changes.*** To avoid automatically picking up releases like this, you should either be pinning the exact version of `esbuild` in your `package.json` file (recommended) or be using a version range syntax that only accepts patch upgrades such as `^0.23.0` or `~0.23.0`. See npm's documentation about [semver](https://docs.npmjs.com/cli/v6/using-npm/semver/) for more information. - Drop support for older platforms ([#​3902](https://redirect.github.com/evanw/esbuild/pull/3902)) This release drops support for the following operating system: - macOS 10.15 Catalina This is because the Go programming language dropped support for this operating system version in Go 1.23, and this release updates esbuild from Go 1.22 to Go 1.23. Go 1.23 now requires macOS 11 Big Sur or later. Note that this only affects the binary esbuild executables that are published to the esbuild npm package. It's still possible to compile esbuild's source code for these older operating systems. If you need to, you can compile esbuild for yourself using an older version of the Go compiler (before Go version 1.23). That might look something like this: git clone https://github.com/evanw/esbuild.git cd esbuild go build ./cmd/esbuild ./esbuild --version - Fix class field decorators in TypeScript if `useDefineForClassFields` is `false` ([#​3913](https://redirect.github.com/evanw/esbuild/issues/3913)) Setting the `useDefineForClassFields` flag to `false` in `tsconfig.json` means class fields use the legacy TypeScript behavior instead of the standard JavaScript behavior. Specifically they use assign semantics instead of define semantics (e.g. setters are triggered) and fields without an initializer are not initialized at all. However, when this legacy behavior is combined with standard JavaScript decorators, TypeScript switches to always initializing all fields, even those without initializers. Previously esbuild incorrectly continued to omit field initializers for this edge case. These field initializers in this case should now be emitted starting with this release. - Avoid incorrect cycle warning with `tsconfig.json` multiple inheritance ([#​3898](https://redirect.github.com/evanw/esbuild/issues/3898)) TypeScript 5.0 introduced multiple inheritance for `tsconfig.json` files where `extends` can be an array of file paths. Previously esbuild would incorrectly treat files encountered more than once when processing separate subtrees of the multiple inheritance hierarchy as an inheritance cycle. With this release, `tsconfig.json` files containing this edge case should work correctly without generating a warning. - Handle Yarn Plug'n'Play stack overflow with `tsconfig.json` ([#​3915](https://redirect.github.com/evanw/esbuild/issues/3915)) Previously a `tsconfig.json` file that `extends` another file in a package with an `exports` map could cause a stack overflow when Yarn's Plug'n'Play resolution was active. This edge case should work now starting with this release. - Work around more issues with Deno 1.31+ ([#​3917](https://redirect.github.com/evanw/esbuild/pull/3917)) This version of Deno broke the `stdin` and `stdout` properties on command objects for inherited streams, which matters when you run esbuild's Deno module as the entry point (i.e. when `import.meta.main` is `true`). Previously esbuild would crash in Deno 1.31+ if you ran esbuild like that. This should be fixed starting with this release. This fix was contributed by [@​Joshix-1](https://redirect.github.com/Joshix-1). </details> <details> <summary>html-validate/html-validate (html-validate)</summary> ### [`v8.23.0`](https://gitlab.com/html-validate/html-validate/blob/HEAD/CHANGELOG.md#8230-2024-09-22) [Compare Source](https://gitlab.com/html-validate/html-validate/compare/v8.22.0...v8.23.0) ##### Features - **deps:** support vitest v2 ([860b0c0](https://gitlab.com/html-validate/html-validate/commit/860b0c02510ef7e40cd2fd54b7f83143643b3718)) </details> <details> <summary>pmndrs/jotai (jotai)</summary> ### [`v2.10.0`](https://redirect.github.com/pmndrs/jotai/releases/tag/v2.10.0) [Compare Source](https://redirect.github.com/pmndrs/jotai/compare/v2.9.3...v2.10.0) It comes with another significant internal change to address some edge cases. Since v2.9.0, we've been working on some internal refactors to support more edge cases and clean up the code. Users are encouraged to update to the new versions eventually, but if you're satisfied with the current situation and prefer to avoid temporary instability, you can stick with v2.8.4 for now. #### What's Changed - breaking(core): avoid continuable promise in store api by [@​dai-shi](https://redirect.github.com/dai-shi) in [https://github.com/pmndrs/jotai/pull/2695](https://redirect.github.com/pmndrs/jotai/pull/2695) #### New Contributors - [@​sphinxrave](https://redirect.github.com/sphinxrave) made their first contribution in [https://github.com/pmndrs/jotai/pull/2653](https://redirect.github.com/pmndrs/jotai/pull/2653) - [@​mxthxngx](https://redirect.github.com/mxthxngx) made their first contribution in [https://github.com/pmndrs/jotai/pull/2712](https://redirect.github.com/pmndrs/jotai/pull/2712) - [@​hoangvu12](https://redirect.github.com/hoangvu12) made their first contribution in [https://github.com/pmndrs/jotai/pull/2716](https://redirect.github.com/pmndrs/jotai/pull/2716) - [@​YuHyeonWook](https://redirect.github.com/YuHyeonWook) made their first contribution in [https://github.com/pmndrs/jotai/pull/2734](https://redirect.github.com/pmndrs/jotai/pull/2734) **Full Changelog**: https://github.com/pmndrs/jotai/compare/v2.9.3...v2.10.0 </details> <details> <summary>lucide-icons/lucide (lucide-react)</summary> ### [`v0.445.0`](https://redirect.github.com/lucide-icons/lucide/releases/tag/0.445.0): New icons 0.445.0 [Compare Source](https://redirect.github.com/lucide-icons/lucide/compare/0.444.0...0.445.0) #### New icons 🎨 - `briefcase-conveyor-belt` ([#​2431](https://redirect.github.com/lucide-icons/lucide/issues/2431)) by [@​jguddas](https://redirect.github.com/jguddas) - `message-square-lock` ([#​2430](https://redirect.github.com/lucide-icons/lucide/issues/2430)) by [@​jguddas](https://redirect.github.com/jguddas) ### [`v0.444.0`](https://redirect.github.com/lucide-icons/lucide/releases/tag/0.444.0): New icons 0.444.0 [Compare Source](https://redirect.github.com/lucide-icons/lucide/compare/0.443.0...0.444.0) #### Modified Icons 🔨 - `loader-pinwheel` ([#​2470](https://redirect.github.com/lucide-icons/lucide/issues/2470)) by [@​jguddas](https://redirect.github.com/jguddas) ### [`v0.443.0`](https://redirect.github.com/lucide-icons/lucide/releases/tag/0.443.0): New icons 0.443.0 [Compare Source](https://redirect.github.com/lucide-icons/lucide/compare/0.442.0...0.443.0) #### Modified Icons 🔨 - `circle-stop` ([#​2479](https://redirect.github.com/lucide-icons/lucide/issues/2479)) by [@​jguddas](https://redirect.github.com/jguddas) ### [`v0.442.0`](https://redirect.github.com/lucide-icons/lucide/releases/tag/0.442.0): New icons 0.442.0 [Compare Source](https://redirect.github.com/lucide-icons/lucide/compare/0.441.0...0.442.0) #### Modified Icons 🔨 - `messages-square` ([#​2429](https://redirect.github.com/lucide-icons/lucide/issues/2429)) by [@​jguddas](https://redirect.github.com/jguddas) - `octagon-pause` ([#​2485](https://redirect.github.com/lucide-icons/lucide/issues/2485)) by [@​jguddas](https://redirect.github.com/jguddas) </details> <details> <summary>mswjs/msw (msw)</summary> ### [`v2.4.9`](https://redirect.github.com/mswjs/msw/releases/tag/v2.4.9) [Compare Source](https://redirect.github.com/mswjs/msw/compare/v2.4.8...v2.4.9) #### v2.4.9 (2024-09-20) ##### Bug Fixes - **ClientRequest:** support `Request` as init when recording raw headers ([#​2293](https://redirect.github.com/mswjs/msw/issues/2293)) ([`bf982ea`](https://redirect.github.com/mswjs/msw/commit/bf982eaa70ddd5d08706b8877ceb6c6c2517f660)) [@​kettanaito](https://redirect.github.com/kettanaito) </details> <details> <summary>napi-rs/napi-rs (napi)</summary> ### [`v3.0.0-alpha.11`](https://redirect.github.com/napi-rs/napi-rs/releases/tag/napi%403.0.0-alpha.11) [Compare Source](https://redirect.github.com/napi-rs/napi-rs/compare/[email protected]@3.0.0-alpha.11) #### What's Changed - refactor(napi-derive): expand order by [@​Brooooooklyn](https://redirect.github.com/Brooooooklyn) in [https://github.com/napi-rs/napi-rs/pull/2265](https://redirect.github.com/napi-rs/napi-rs/pull/2265) **Full Changelog**: https://github.com/napi-rs/napi-rs/compare/[email protected]@3.0.0-alpha.11 ### [`v3.0.0-alpha.10`](https://redirect.github.com/napi-rs/napi-rs/releases/tag/napi%403.0.0-alpha.10) [Compare Source](https://redirect.github.com/napi-rs/napi-rs/compare/[email protected]@3.0.0-alpha.10) #### What's Changed - fix(napi): nullptr handling in `TypedArray`s by [@​Xanewok](https://redirect.github.com/Xanewok) in [https://github.com/napi-rs/napi-rs/pull/2258](https://redirect.github.com/napi-rs/napi-rs/pull/2258) - chore: enable corepack in Debian base Dockerfile by [@​stevefan1999-personal](https://redirect.github.com/stevefan1999-personal) in [https://github.com/napi-rs/napi-r </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/toeverything/AFFiNE). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6ImNhbmFyeSIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
bucket.uploadif they are specified by the user.I was facing an issue where artifacts could not be uploaded to a bucket that had uniform bucket-level access, which essentially meant that files could not be uploaded that had specified
privateorpublicorpredefinedAcl. This change removes those fields from thebucket.uploadcall unless they are added by the user.