-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add integration for @electron/fuses
#8588
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilder can integrate @electron/fuses while also allowing scheme.json to still generate correctly
…older versions of electron
🦋 Changeset detectedLatest commit: 523fe4c The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…ctron-fuses # Conflicts: # packages/app-builder-lib/package.json # pnpm-lock.yaml
mmaietta
force-pushed
the
feat/electron-fuses
branch
from
October 12, 2024 16:07
87e6048
to
957e02a
Compare
…viewing of generated docs site
beyondkmp
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: adding hardcoded interface for FuseV1Config so that electron-builder can integrate @electron/fuses while also allowing scheme.json to still generated correctly
Resolves: #6365
There will be a new configuration object
electronFuses: FuseOptionsV1
and it executes@electron/fuses
directly before signing as is recommended on the repo instructions: https://github.com/electron/fuses?tab=readme-ov-file#apple-siliconI've also opened it up as a convenience method should you want to keep custom logic in your
afterPack
method called viaelectron-builder/packages/app-builder-lib/src/platformPackager.ts
Line 398 in f5cc9ed
It allows you to pass a full
FuseConfig
into the method as opposed to having electron-builder parsingelectronFuses
config property.Taking this ☝️ approach would also allow you to set
strictlyRequireAllFuses: true
should you so desire. (I couldn't pass any var of this in-code due to https://github.com/electron/fuses/blob/0cf2a177e70dd81cc74c4449847287cd65ea140b/src/config.ts#L31-L34)The fuse
FuseV1Options.EnableEmbeddedAsarIntegrityValidation = true
is supported now as well.Tested locally and app runs