Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(keygen): Add host property to support self-hosted Keygen instances #8711

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

feat(keygen): Add host property to support self-hosted Keygen instances #8711

wants to merge 8 commits into from
+27 −2

Conversation

hrueger
Copy link
Contributor

@hrueger hrueger commented Nov 27, 2024

fixes #8704

I haven't tested this, though. Is there anything else I'd have to modify e.g. docs?

Thanks in advance!

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 27, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 230a7a4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
app-builder-lib Major
builder-util-runtime Minor
electron-publish Major
electron-updater Minor
dmg-builder Major
electron-builder-squirrel-windows Major
electron-builder Major
electron-forge-maker-appimage Major
electron-forge-maker-nsis-web Major
electron-forge-maker-nsis Major
electron-forge-maker-snap Major
builder-util Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hrueger hrueger requested a review from mmaietta December 3, 2024 21:15
@hrueger
Copy link
Contributor Author

hrueger commented Dec 3, 2024

Hi @mmaietta,
thanks for the review, I fixed the few points 👍

@mmaietta mmaietta changed the title feat(keygen): set host in config feat(keygen): Add host property to support self-hosted Keygen instances Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmaietta mmaietta Awaiting requested review from mmaietta

Assignees
No one assigned
Labels
app-builder-lib builder-util electron-publish electron-updater
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for selfhosted Keygen
2 participants
@hrueger @mmaietta