Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(keygen): Add host property to support self-hosted Keygen instances #8711

Merged
merged 8 commits into from
Dec 6, 2024

Conversation

hrueger
Copy link
Contributor

@hrueger hrueger commented Nov 27, 2024

fixes #8704

I haven't tested this, though. Is there anything else I'd have to modify e.g. docs?

Thanks in advance!

Copy link

changeset-bot bot commented Nov 27, 2024

🦋 Changeset detected

Latest commit: 230a7a4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
app-builder-lib Major
builder-util-runtime Minor
electron-publish Major
electron-updater Minor
dmg-builder Major
electron-builder-squirrel-windows Major
electron-builder Major
electron-forge-maker-appimage Major
electron-forge-maker-nsis-web Major
electron-forge-maker-nsis Major
electron-forge-maker-snap Major
builder-util Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hrueger hrueger requested a review from mmaietta December 3, 2024 21:15
@hrueger
Copy link
Contributor Author

hrueger commented Dec 3, 2024

Hi @mmaietta,
thanks for the review, I fixed the few points 👍

@mmaietta mmaietta changed the title feat(keygen): set host in config feat(keygen): Add host property to support self-hosted Keygen instances Dec 3, 2024
@mmaietta mmaietta merged commit 6f0fb8e into electron-userland:master Dec 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for selfhosted Keygen
2 participants