Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #60

Merged
merged 52 commits into from
Apr 18, 2019
Merged

Develop #60

merged 52 commits into from
Apr 18, 2019

Conversation

betzrhodes
Copy link

Add 'reproducible artifacts built from GitHub' feature.

Fixed issues:

#52

Fedor Uporov and others added 30 commits March 23, 2019 14:14
…th local 'reproducible artifacts built from github' feature.
… logic if options were not passed to read() method.
Add "reproducible artifacts built from github" feature.
@betzrhodes
Copy link
Author

betzrhodes commented Apr 16, 2019

Waiting on release, because this is now failing automated tests.

[11:52:24] [npm test] > [email protected] test /opt/JetBrains/TeamCity/buildAgent/work/a7410fd4a46c41a6
[11:52:24] [npm test] > jasmine
[11:52:24] [npm test]
[11:52:24] [npm test] /opt/JetBrains/TeamCity/buildAgent/work/a7410fd4a46c41a6/src/Machine.js:703
[11:52:24] [npm test] this.directives = { ...context };
[11:52:24] [npm test] ^^^
[11:52:24] [npm test]
[11:52:24] [npm test] SyntaxError: Unexpected token ...
[11:52:24] [npm test] at createScript (vm.js:74:10)
[11:52:24] [npm test] at Object.runInThisContext (vm.js:116:10)
[11:52:24] [npm test] at Module._compile (module.js:533:28)
[11:52:24] [npm test] at Object.Module._extensions..js (module.js:580:10)
[11:52:24] [npm test] at Module.load (module.js:503:32)
[11:52:24] [npm test] at tryModuleLoad (module.js:466:12)
[11:52:24] [npm test] at Function.Module._load (module.js:458:3)
[11:52:24] [npm test] at Module.require (module.js:513:17)
[11:52:24] [npm test] at require (internal/module.js:11:18)
[11:52:24] [npm test] at Object. (/opt/JetBrains/TeamCity/buildAgent/work/a7410fd4a46c41a6/src/AstParser.js:30:22)
[11:52:24] [Step 3/3] Process exited with code 1

@FedorUporov @YaroslavYaroslavtsev any ideas on how to address this?

src/Machine.js Outdated
_loadAndMergeDirectives(context) {
if (!this.directivesUseFile) {
if (this.directivesSaveFile) {
this.directives = { ...context };
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is causing automated tests to fail.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is PR, which should fix an issue above:
#62

Fedor Uporov and others added 3 commits April 18, 2019 11:38
Fedor Uporov and others added 2 commits April 18, 2019 13:13
 Increase minimum nodejs version and do not use object spread operators.
@betzrhodes betzrhodes merged commit 7f149f2 into master Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants