Merge branch 'main' into switch-output-location

.devcontainer/Dockerfile

@@ -1,4 +1,4 @@
-FROM mcr.microsoft.com/devcontainers/typescript-node:16-bookworm
+FROM mcr.microsoft.com/devcontainers/typescript-node:18-bookworm
 
 RUN apt-get install -y wget bzip2
 

.github/workflows/build.yml

@@ -9,7 +9,7 @@ on:
       - 'release-*'
 
 env:
-  NODE_VERSION: 16.17.1
+  NODE_VERSION: 18.17.1
   PYTHON_VERSION: '3.10' # YML treats 3.10 the number as 3.1, so quotes around 3.10
   # Force a path with spaces and to test extension works in these scenarios
   # Unicode characters are causing 2.7 failures so skip that for now.
@@ -120,7 +120,7 @@ jobs:
         # macOS runners are expensive, and we assume that Ubuntu is enough to cover the Unix case.
         os: [ubuntu-latest, windows-latest]
         # Run the tests on the oldest and most recent versions of Python.
-        python: ['3.8', '3.x']
+        python: ['3.8', '3.x', '3.12-dev']
 
     steps:
       - name: Checkout

.github/workflows/pr-check.yml

@@ -8,7 +8,7 @@ on:
       - release*
 
 env:
-  NODE_VERSION: 16.17.1
+  NODE_VERSION: 18.17.1
   PYTHON_VERSION: '3.10' # YML treats 3.10 the number as 3.1, so quotes around 3.10
   MOCHA_REPORTER_JUNIT: true # Use the mocha-multi-reporters and send output to both console (spec) and JUnit (mocha-junit-reporter). Also enables a reporter which exits the process running the tests if it haven't already.
   ARTIFACT_NAME_VSIX: ms-python-insiders-vsix
@@ -94,7 +94,7 @@ jobs:
         # macOS runners are expensive, and we assume that Ubuntu is enough to cover the Unix case.
         os: [ubuntu-latest, windows-latest]
         # Run the tests on the oldest and most recent versions of Python.
-        python: ['3.8', '3.x']
+        python: ['3.8', '3.x', '3.12-dev']
 
     steps:
       - name: Checkout

.nvmrc

@@ -1 +1 @@
-v16.17.1
+v18.17.1

README.md

@@ -37,7 +37,7 @@ Extensions installed through the marketplace are subject to the [Marketplace Ter
 
 ## Jupyter Notebook quick start
 
-The Python extension offers support for Jupyter notebooks via the [Jupyter extension](https://marketplace.visualstudio.com/items?itemName=ms-toolsai.jupyter) to provide you a great Python notebook experience in VS Code. 
+The Python extension offers support for Jupyter notebooks via the [Jupyter extension](https://marketplace.visualstudio.com/items?itemName=ms-toolsai.jupyter) to provide you a great Python notebook experience in VS Code.
 
 - Install the [Jupyter extension](https://marketplace.visualstudio.com/items?itemName=ms-toolsai.jupyter).
 
@@ -60,7 +60,6 @@ Open the Command Palette (Command+Shift+P on macOS and Ctrl+Shift+P on Windows/L
 | `Python: Select Interpreter`          | Switch between Python interpreters, versions, and environments.                                                                                                |
 | `Python: Start REPL`                  | Start an interactive Python REPL using the selected interpreter in the VS Code terminal.                                                                       |
 | `Python: Run Python File in Terminal` | Runs the active Python file in the VS Code terminal. You can also run a Python file by right-clicking on the file and selecting `Run Python File in Terminal`. |
-| `Python: Select Linter`               | Switch from Pylint to Flake8 or other supported linters.                                                                                                       |
 | `Format Document`                     | Formats code using the provided [formatter](https://code.visualstudio.com/docs/python/editing#_formatting) in the `settings.json` file.                        |
 | `Python: Configure Tests`             | Select a test framework and configure it to display the Test Explorer.                                                                                         |
 
@@ -82,7 +81,7 @@ Learn more about the rich features of the Python extension:
 
 -   [Environments](https://code.visualstudio.com/docs/python/environments): Automatically activate and switch between virtualenv, venv, pipenv, conda and pyenv environments
 
--   [Refactoring](https://code.visualstudio.com/docs/python/editing#_refactoring): Restructure your Python code with variable extraction and method extraction. Additionally, there is componentized support to enable additional refactoring, such as import sorting, through extensions including [isort](https://marketplace.visualstudio.com/items?itemName=ms-python.isort) and [Ruff](https://marketplace.visualstudio.com/items?itemName=charliermarsh.ruff). 
+-   [Refactoring](https://code.visualstudio.com/docs/python/editing#_refactoring): Restructure your Python code with variable extraction and method extraction. Additionally, there is componentized support to enable additional refactoring, such as import sorting, through extensions including [isort](https://marketplace.visualstudio.com/items?itemName=ms-python.isort) and [Ruff](https://marketplace.visualstudio.com/items?itemName=charliermarsh.ruff).
 
 
 

build/azure-pipeline.pre-release.yml

@@ -33,7 +33,7 @@ extends:
     buildSteps:
       - task: NodeTool@0
         inputs:
-          versionSpec: '16.17.1'
+          versionSpec: '18.17.1'
         displayName: Select Node version
 
       - task: UsePythonVersion@0

build/azure-pipeline.stable.yml

@@ -28,7 +28,7 @@ extends:
     buildSteps:
       - task: NodeTool@0
         inputs:
-          versionSpec: '16.17.1'
+          versionSpec: '18.17.1'
         displayName: Select Node version
 
       - task: UsePythonVersion@0

build/azure-pipelines/pipeline.yml

@@ -37,13 +37,13 @@ extends:
         testPlatforms:
           - name: Linux
             nodeVersions:
-              - 16.17.1
+              - 18.17.1
           - name: MacOS
             nodeVersions:
-              - 16.17.1
+              - 18.17.1
           - name: Windows
             nodeVersions:
-              - 16.17.1
+              - 18.17.1
         testSteps:
           - template: /build/azure-pipelines/templates/test-steps.yml@self
             parameters:

gulpfile.js

@@ -39,18 +39,19 @@ gulp.task('compileCore', (done) => {
         .on('finish', () => (failed ? done(new Error('TypeScript compilation errors')) : done()));
 });
 
-const apiTsProject = ts.createProject('./pythonExtensionApi/tsconfig.json', { typescript });
-
 gulp.task('compileApi', (done) => {
-    let failed = false;
-    apiTsProject
-        .src()
-        .pipe(apiTsProject())
-        .on('error', () => {
-            failed = true;
+    spawnAsync('npm', ['run', 'compileApi'], undefined, true)
+        .then((stdout) => {
+            if (stdout.includes('error')) {
+                done(new Error(stdout));
+            } else {
+                done();
+            }
         })
-        .js.pipe(gulp.dest('./pythonExtensionApi/out'))
-        .on('finish', () => (failed ? done(new Error('TypeScript compilation errors')) : done()));
+        .catch((ex) => {
+            console.log(ex);
+            done(new Error('TypeScript compilation errors', ex));
+        });
 });
 
 gulp.task('compile', gulp.series('compileCore', 'compileApi'));