Update config_flow #143
Merged
Update config_flow #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't know if this works, but at least it's a start.
|
Implemented the current PR on my on PROD system, and I'm not 100% sure, but it seems to work. I'm pretty sure there's a much cleaner implementation though. Status right now: Offset changes on the HVAC when I turn up the temperature in Peaq. But still no offsets-calculation - I know that can take some time though, so let's see tomorrow. |
|
Update: Offsets are working! 🚀 But, I think the whole config flow needs to be looked at. Not sure this is the correct fix. |
|
@elden1337 Do you have time to look this through? Maybe even improve it? |
|
Looks fine. Thanks. Merging and deploying when I am available at a computer and not working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't know if this works, but at least it's a start.
Based on https://github.com/home-assistant/developers.home-assistant/blob/a542ab2f6971faa3784596e12249af20a01fa82e/blog/2024-11-12-options-flow.md
Fixes #142