Skip to content

Commit

Permalink
Auto merge of rust-lang#3083 - jhbabon:fix-warning-in-feature-tests, …
Browse files Browse the repository at this point in the history
…r=alexcrichton

FIX: Properly close dep_feature_in_cmd_line test.

It was including the test `all_features_flag_enables_all_features` inside its function body and it was causing this warning when executing `cargo test`:

```
   Compiling cargo v0.13.0 (file:///home/jhbabon/Code/cargo)
tests/features.rs:965:1: 1006:2 warning: function is never used: `all_features_flag_enables_all_features`, #[warn(dead_code)] on by default
tests/features.rs:965 fn all_features_flag_enables_all_features() {
                      ^
tests/features.rs:964:1: 964:8 warning: unused attribute, #[warn(unused_attributes)] on by default
tests/features.rs:964 #[test]
                      ^~~~~~~
     Running target/debug/features-e37991fdf417989c
```
  • Loading branch information
bors authored Sep 11, 2016
2 parents 398de25 + 1f88ad5 commit b931a0f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/features.rs
Original file line number Diff line number Diff line change
Expand Up @@ -960,6 +960,7 @@ fn dep_feature_in_cmd_line() {
execs().with_status(101).with_stderr("\
[ERROR] feature names may not contain slashes: `bar/some-feat`
"));
}

#[test]
fn all_features_flag_enables_all_features() {
Expand Down Expand Up @@ -1004,4 +1005,3 @@ fn all_features_flag_enables_all_features() {
assert_that(p.cargo_process("build").arg("--all-features"),
execs().with_status(0));
}
}

0 comments on commit b931a0f

Please sign in to comment.