-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complex query and pagination #38
base: master
Are you sure you want to change the base?
Conversation
Looks good to me, thanks @kemal-bay! Before merging this, I want to place some notes in the documentation specifically about doing efficient searching in Elasticsearch. During working on this project, I am noticing that many people are not really coming from an Elasticsearch background. This is not specifically a bad thing, however, people may not be aware of the setbacks of using specific methods, and what problems may arise from using them incorrectly. We should attach a warning on the search functions in the README.md similar to what is in the Elasticsearch guide (https://www.elastic.co/guide/en/elasticsearch/guide/current/pagination.html).
I think that if people are just dropping Elasticsearch into their Laravel applications without much ES-specific knowledge, we should do our part to 'educate' developers using this module about possible setbacks and warnings for implementations. |
@timgws please merge this commit, pagination doesn't work at the moment |
@szente, I will merge this, as soon as the functionality has been put into the readme file, and the warning put in as per the request I made in February. Feel free to add another PR for adding the note in the README file, but until that has been done, this will not be merged. |
hello @timgws pagination is not accurate. Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i want to know how you called the pagination function into the view? @kemal-bay
In order to make a proper pagination, I added a function called complexSearchAndPaginate to trait file.
Issue #33