Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bypassing PFX certificate loading #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rafaelvzago
Copy link

@rafaelvzago rafaelvzago commented Jan 17, 2023

What does this PR do?

This PR aims to fix the PFX error that occurs when running the makelogs application. It does so by implementing a javascript instruction ssl:{ rejectUnauthorized: false, pfx: [] } that bypasses the error and allows the application to run smoothly.

Why is this change necessary?

Currently, when running the makelogs application, some users are facing a PFX error that prevents them from using the application as intended. This change addresses this issue by bypassing the error, and making the application accessible to all users.

How has this change been tested?

This change has been tested by running the makelogs application with the new instruction in place and confirming that the PFX error is no longer present. Additionally, the application was tested to ensure that it runs smoothly and no other issues have been encountered.

What are the relevant issue numbers?

This PR is related to issue #53

Screenshots (if appropriate)

N/A

Notes for reviewers

Please review the code changes and ensure that they are implemented correctly and do not cause any other issues. Additionally, please test the application with the new instruction in place to ensure that the PFX error is successfully bypassed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Please let me know if you have any questions or concerns.

Ref: https://www.gooksu.com/2022/01/generate-test-data-using-elastics-makelogs/

Signed-off-by: Rafael Zago [email protected]

@cla-checker-service
Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
4f1d481

Please, read and sign the above mentioned agreement if you want to contribute to this project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant