Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: improve plugin logging xp #13038

Closed
wants to merge 24 commits into from
Closed

Refactor: improve plugin logging xp #13038

wants to merge 24 commits into from

Commits on Jul 27, 2021

  1. Refactor: keep a Java plugin.id + cache the Ruby one

    @kares
    kares committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    be16008 View commit details
    Browse the repository at this point in the history

  2. Refactor: extract context for readability

    @kares
    kares committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    b5af811 View commit details
    Browse the repository at this point in the history

  3. Refactor: filter to provide logging context on close

    @kares
    kares committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    fc1345c View commit details
    Browse the repository at this point in the history

  4. Refactor: output to provide logging context on close

    @kares
    kares committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    e24b0f5 View commit details
    Browse the repository at this point in the history

  5. Refactor: filter.register to have logging context

    @kares
    kares committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    067a442 View commit details
    Browse the repository at this point in the history

  6. Refactor: output.register to have logging context

    @kares
    kares committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    64363ec View commit details
    Browse the repository at this point in the history

  7. Refactor: simplify config_hash generation

    @kares
    kares committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    163652a View commit details
    Browse the repository at this point in the history

  8. Refactor: centralize plugin id generation

    @kares
    kares committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    660fe51 View commit details
    Browse the repository at this point in the history

  9. Refactor: simplify one less Map to allocate

    @kares
    kares committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    ef3c2d3 View commit details
    Browse the repository at this point in the history

  10. Refactor: do not rely on IR generated ids 

    - previously (w a source) we would always end up with an id
- (potentially auto) generated from `extractIdFromLIR`
- unless an explicit id is set in the configuration

the generated default id was a "slow" graph content hash
(same configuration would always end up with the same id)
    @kares
    kares committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    a39068b View commit details
    Browse the repository at this point in the history

  11. Feat: (fast) generated 16 hex character plugin ids

    @kares
    kares committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    b3613f1 View commit details
    Browse the repository at this point in the history

  12. Refactor: use same plugin id generation 

    (in tests) as when booting the pipeline
    @kares
    kares committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    3686d22 View commit details
    Browse the repository at this point in the history

  13. Test: adjust (random) plugin.id expectations

    @kares
    kares committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    fc3f898 View commit details
    Browse the repository at this point in the history

  14. Refactor: do not generate singleton_class for Loggable 

    what was meant was likely to do a `self.class.logger` here
    @kares
    kares committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    893dfc8 View commit details
    Browse the repository at this point in the history

  15. simplify logging Ruby facade impl + fix trace?

    @kares
    kares committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    c265c1d View commit details
    Browse the repository at this point in the history

  16. Refactor: use asString (CharSequence) where possible 

    also changes the contract from msg.to_str to msg.to_s
    @kares
    kares committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    97a1ec3 View commit details
    Browse the repository at this point in the history

  17. align msg.to_s logging convention change

    @kares
    kares committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    a48bc36 View commit details
    Browse the repository at this point in the history

  18. Refactor: prepare for plugin.logger customization 

    also improves performance of plugin.logger invocations
    @kares
    kares committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    6a30707 View commit details
    Browse the repository at this point in the history

  19. javadoc for logger methods + prepare for sub-classing

    @kares
    kares committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    da95262 View commit details
    Browse the repository at this point in the history

  20. Feat: a custom logger per plugin instance

    @kares
    kares committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    b401a76 View commit details
    Browse the repository at this point in the history

  21. Test: adjust spec to consider PluginLogger

    @kares
    kares committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    6a6b93f View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2021

  1. Chore: keep a todo for plugin.class.logger method

    @kares
    kares committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    0a51727 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2021

  1. only set plugin.id if isn't already set 

    ... for restore to keep the previously set id
    @kares
    kares committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    0d13c83 View commit details
    Browse the repository at this point in the history

  2. Revert back to generating same ids (from LIR)

    @kares
    kares committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    5d56b06 View commit details
    Browse the repository at this point in the history