Backport PR #12749 to 7.x: internal-monitoring: use configured ssl verification mode #12750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) Upstream `ElasticsearchOptions#es_options_from_settings` already uses the setting `elasticsearch.ssl.verification_mode` to produce an appropriate boolean-valued `ssl_certificate_verification` in our `es_settings` hash, so we can rely on it instead of re-checking equality with a string. (cherry picked from commit d5becc0)
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #12749 to 7.x branch. Original message:
What does this PR do?
Fixes Internal Monitoring to correctly rely on the
monitoring.elasticsearch.ssl.verification_modesetting.Why is it important/What is the impact to the user?
Ensures that explicitly-configured options are used.
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration files (and/or docker env variables)How to test this PR locally
Related issues