-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add pipeline.ecs_compatibility docs #12421
Conversation
jenkins test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My apologies. This one fell through the cracks.
I left a comment inline about possibly linking to your ECS docs in #12830.
Otherwise, it builds cleanly and LGTM. 🎉
I
docs/static/settings-file.asciidoc
Outdated
* `v1` | ||
* `v2` | ||
|
||
This option allows the early opt-in (or preemptive opt-out) of ECS Compatibility modes in plugins, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a link to the doc goodness (<>) in #12830 after it is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to link: {logstash-ref}/ecs-ls.html
1a7b0ed
to
f8989b7
Compare
f8989b7
to
ca406e4
Compare
ca406e4
to
a31fcde
Compare
(cherry picked from commit 4056cb1)
(cherry picked from commit 4056cb1)
* master: Update releases list (elastic#13149) Bundler: freeze lockfile on run, and "normalize" platform on plugin changes (elastic#13015) Doc: Move shared region tags for breaking changes to 8.0.0 content (elastic#13131) Update Snakeyaml version to 1.29 (elastic#13129) Doc: Add breaking changes to breaking changes page (elastic#13130) Added faraday-* and ruby2_keywords notices to licences list (elastic#13126) Release notes draft for 8.0.0-alpha1 (elastic#13098) valid variable expansion for the batch files (elastic#12912) Doc: Enhance and expand DLQ docs (elastic#12959) Update releases list with 7.13.4 (elastic#13088) Doc:Fix typo and adjust keystore text (elastic#12779) doc: add pipeline.ecs_compatibility docs (elastic#12421) ecs_compatibility: revert breaking change; keep `disabled` as default for 8.0.0 (elastic#13080) Doc: Add kafka schema registry setting to troubleshooting (elastic#13073) [Test] Fix Unix acceptance tests (elastic#13071) Move retrieval of Stack version from Gradle's configuration to execution (elastic#13042) Update releases list with 6.8.17 and 7.13.3 (elastic#13041) Docs: keep elastic_app_search output meta-data (elastic#13048) Fix LS benchmarking tool to work with releases >= 7.10.0 (elastic#13052) Revert "Change Gradle's :logstash-integration-tests:integrationTests task to depends on copyES (elastic#12847)" (elastic#13045)
What does this PR do?
Adds doc section for
pipeline.ecs_compatibility
setting.Backport targets:
7.10
7.x
Why is it important/What is the impact to the user?
While this copy already exists in the
--help
output for the logstash command-line executable, bringing it to the web documentation makes it more accessible.Checklist
My code follows the style guidelines of this projectI have commented my code, particularly in hard-to-understand areasI have made corresponding change to the default configuration files (and/or docker env variables)I have added tests that prove my fix is effective or that my feature worksHow to test this PR locally
Click through to Docs Build, or observe this handy screenshot:
Related issues
#12305