Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add pipeline.ecs_compatibility docs #12421

Merged
merged 1 commit into from
Jul 20, 2021

Conversation

yaauie
Copy link
Member

@yaauie yaauie commented Nov 7, 2020

What does this PR do?

Adds doc section for pipeline.ecs_compatibility setting.

Backport targets:

  • 7.10
  • 7.x

Why is it important/What is the impact to the user?

While this copy already exists in the --help output for the logstash command-line executable, bringing it to the web documentation makes it more accessible.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

How to test this PR locally

Click through to Docs Build, or observe this handy screenshot:

Screen Shot 2020-11-06 at 6 53 41 PM

Related issues

#12305

@karenzone
Copy link
Contributor

jenkins test this please

Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies. This one fell through the cracks.
I left a comment inline about possibly linking to your ECS docs in #12830.

Otherwise, it builds cleanly and LGTM. 🎉

I

* `v1`
* `v2`

This option allows the early opt-in (or preemptive opt-out) of ECS Compatibility modes in plugins,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a link to the doc goodness (<>) in #12830 after it is merged.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to link: {logstash-ref}/ecs-ls.html

@yaauie yaauie force-pushed the document-ecs-compatibility branch from f8989b7 to ca406e4 Compare July 20, 2021 21:43
@yaauie yaauie force-pushed the document-ecs-compatibility branch from ca406e4 to a31fcde Compare July 20, 2021 21:48
@yaauie yaauie merged commit 4056cb1 into elastic:master Jul 20, 2021
yaauie added a commit to yaauie/logstash that referenced this pull request Jul 20, 2021
@yaauie yaauie added the v7.15.0 label Jul 20, 2021
yaauie added a commit to yaauie/logstash that referenced this pull request Jul 20, 2021
@yaauie yaauie added the v7.14.0 label Jul 20, 2021
yaauie added a commit that referenced this pull request Jul 20, 2021
yaauie added a commit that referenced this pull request Jul 20, 2021
kares added a commit to kares/logstash that referenced this pull request Aug 23, 2021
* master:
  Update releases list (elastic#13149)
  Bundler: freeze lockfile on run, and "normalize" platform on plugin changes (elastic#13015)
  Doc: Move shared region tags for breaking changes to 8.0.0 content (elastic#13131)
  Update Snakeyaml version to 1.29 (elastic#13129)
  Doc: Add breaking changes to breaking changes page (elastic#13130)
  Added faraday-* and ruby2_keywords notices to licences list (elastic#13126)
  Release notes draft for 8.0.0-alpha1 (elastic#13098)
  valid variable expansion for the batch files (elastic#12912)
  Doc: Enhance and expand DLQ docs (elastic#12959)
  Update releases list with 7.13.4 (elastic#13088)
  Doc:Fix typo and adjust keystore text (elastic#12779)
  doc: add pipeline.ecs_compatibility docs (elastic#12421)
  ecs_compatibility: revert breaking change; keep `disabled` as default for 8.0.0 (elastic#13080)
  Doc: Add kafka schema registry setting to troubleshooting (elastic#13073)
  [Test] Fix Unix acceptance tests (elastic#13071)
  Move retrieval of Stack version from Gradle's configuration to execution (elastic#13042)
  Update releases list with 6.8.17 and 7.13.3 (elastic#13041)
  Docs: keep elastic_app_search output meta-data (elastic#13048)
  Fix LS benchmarking tool to work with releases >= 7.10.0 (elastic#13052)
  Revert "Change Gradle's :logstash-integration-tests:integrationTests task to depends on copyES (elastic#12847)" (elastic#13045)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants