Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update silence_errors_in_log example #1568

Closed
wants to merge 1 commit into from

Conversation

BBQigniter
Copy link

The example is unfortunately deprecated and does not work anymore. See logstash-plugins/logstash-output-elasticsearch#1159

Also it would be nice to have a list of possible values somewhere - I could not find any

The example is unfortunately deprecated and does not work anymore. See logstash-plugins/logstash-output-elasticsearch#1159 

Also it would be nice to have a list of possible values somewhere - I could not find any
Copy link

cla-checker-service bot commented Nov 21, 2023

💚 CLA has been signed

@karenzone
Copy link
Contributor

@BBQigniter, thank you for your willingness to help us make our docs better. Will you sign the contributor agreement, please? After you sign the CLA, I can evaluate your change and work with you to get your changes retargeted to the source docs that live in https://github.com/logstash-plugins/logstash-output-elasticsearch.

@BBQigniter
Copy link
Author

Hi @karenzone, I signed that thing right after this message popped up, not sure what went wrong.

@karenzone
Copy link
Contributor

@BBQigniter, in that case, thank you for re-signing it. :-)
I'll take a look.

@karenzone
Copy link
Contributor

@BBQigniter, thank you for reading our docs and helping us make them better All plugin doc changes are sourced out of the plugin repo in this case logstash-output-elasticsearch, get generated into doc files, and output into the logstash-docs repo.

The change to the example was included in https://github.com/logstash-plugins/logstash-output-elasticsearch/pull/1159/files#diff-cae5619b3d18ec99c5ccd0a9f6de0c6d3f53343c64692444551a7d29da6863e7, and the change has been propagated to the Logstash Reference.

Related: I opened logstash-plugins/logstash-output-elasticsearch#1177 to preserve your request for more examples.

@karenzone karenzone closed this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants