[Response Ops][Actions] Remove deprecated HTTP APIs (#197510)

Resolves #90382 ## Summary Removes legacy action APIs for 9.0 and updates all tests that still used the legacy APIs to use the current APIs. Also did some renaming of action -> connector in the files I had to touch. Co-authored-by: Elastic Machine <[email protected]>
elastic · Oct 29, 2024 · dd90b67 · dd90b67
1 parent c7b8ca0
commit dd90b67
Show file tree

Hide file tree

Showing 122 changed files with 677 additions and 4,841 deletions.
diff --git a/oas_docs/bundle.json b/oas_docs/bundle.json
diff --git a/oas_docs/bundle.serverless.json b/oas_docs/bundle.serverless.json
diff --git a/oas_docs/output/kibana.serverless.yaml b/oas_docs/output/kibana.serverless.yaml
diff --git a/oas_docs/output/kibana.yaml b/oas_docs/output/kibana.yaml
diff --git a/.../routes/legacy/_mock_handler_arguments.ts → .../server/routes/_mock_handler_arguments.ts b/.../routes/legacy/_mock_handler_arguments.ts → .../server/routes/_mock_handler_arguments.ts
@@ -9,10 +9,10 @@ import { KibanaRequest, KibanaResponseFactory } from '@kbn/core/server';
 import { identity } from 'lodash';
 import type { MethodKeysOf } from '@kbn/utility-types';
 import { httpServerMock } from '@kbn/core/server/mocks';
-import { ActionsRequestHandlerContext } from '../../types';
-import { actionsClientMock } from '../../mocks';
-import { ActionsClientMock } from '../../actions_client/actions_client.mock';
-import { ConnectorType } from '../../application/connector/types';
+import { ActionsRequestHandlerContext } from '../types';
+import { actionsClientMock } from '../mocks';
+import { ActionsClientMock } from '../actions_client/actions_client.mock';
+import { ConnectorType } from '../application/connector/types';
 
 export function mockHandlerArguments(
   {

diff --git a/x-pack/plugins/actions/server/routes/connector/create/create.test.ts b/x-pack/plugins/actions/server/routes/connector/create/create.test.ts
@@ -8,7 +8,7 @@
 import { createConnectorRoute } from './create';
 import { httpServiceMock } from '@kbn/core/server/mocks';
 import { licenseStateMock } from '../../../lib/license_state.mock';
-import { mockHandlerArguments } from '../../legacy/_mock_handler_arguments';
+import { mockHandlerArguments } from '../../_mock_handler_arguments';
 import { verifyAccessAndContext } from '../../verify_access_and_context';
 import { omit } from 'lodash';
 import { actionsClientMock } from '../../../actions_client/actions_client.mock';

diff --git a/x-pack/plugins/actions/server/routes/connector/delete/delete.test.ts b/x-pack/plugins/actions/server/routes/connector/delete/delete.test.ts
@@ -8,7 +8,7 @@
 import { deleteConnectorRoute } from './delete';
 import { httpServiceMock } from '@kbn/core/server/mocks';
 import { licenseStateMock } from '../../../lib/license_state.mock';
-import { mockHandlerArguments } from '../../legacy/_mock_handler_arguments';
+import { mockHandlerArguments } from '../../_mock_handler_arguments';
 import { actionsClientMock } from '../../../mocks';
 import { verifyAccessAndContext } from '../../verify_access_and_context';
 

diff --git a/x-pack/plugins/actions/server/routes/connector/execute/execute.test.ts b/x-pack/plugins/actions/server/routes/connector/execute/execute.test.ts
@@ -8,7 +8,7 @@
 import { executeConnectorRoute } from './execute';
 import { httpServiceMock } from '@kbn/core/server/mocks';
 import { licenseStateMock } from '../../../lib/license_state.mock';
-import { mockHandlerArguments } from '../../legacy/_mock_handler_arguments';
+import { mockHandlerArguments } from '../../_mock_handler_arguments';
 import { asHttpRequestExecutionSource } from '../../../lib';
 import { actionsClientMock } from '../../../actions_client/actions_client.mock';
 import { ActionTypeExecutorResult } from '../../../types';

diff --git a/x-pack/plugins/actions/server/routes/connector/get/get.test.ts b/x-pack/plugins/actions/server/routes/connector/get/get.test.ts
@@ -8,7 +8,7 @@
 import { getConnectorRoute } from './get';
 import { httpServiceMock } from '@kbn/core/server/mocks';
 import { licenseStateMock } from '../../../lib/license_state.mock';
-import { mockHandlerArguments } from '../../legacy/_mock_handler_arguments';
+import { mockHandlerArguments } from '../../_mock_handler_arguments';
 import { actionsClientMock } from '../../../actions_client/actions_client.mock';
 import { verifyAccessAndContext } from '../../verify_access_and_context';
 

diff --git a/x-pack/plugins/actions/server/routes/connector/get_all/get_all.test.ts b/x-pack/plugins/actions/server/routes/connector/get_all/get_all.test.ts
@@ -8,7 +8,7 @@
 import { getAllConnectorsRoute } from './get_all';
 import { httpServiceMock } from '@kbn/core/server/mocks';
 import { licenseStateMock } from '../../../lib/license_state.mock';
-import { mockHandlerArguments } from '../../legacy/_mock_handler_arguments';
+import { mockHandlerArguments } from '../../_mock_handler_arguments';
 import { verifyAccessAndContext } from '../../verify_access_and_context';
 import { actionsClientMock } from '../../../actions_client/actions_client.mock';
 

diff --git a/x-pack/plugins/actions/server/routes/connector/get_all_system/get_all_system.test.ts b/x-pack/plugins/actions/server/routes/connector/get_all_system/get_all_system.test.ts
@@ -8,7 +8,7 @@
 import { getAllConnectorsIncludingSystemRoute } from './get_all_system';
 import { httpServiceMock } from '@kbn/core/server/mocks';
 import { licenseStateMock } from '../../../lib/license_state.mock';
-import { mockHandlerArguments } from '../../legacy/_mock_handler_arguments';
+import { mockHandlerArguments } from '../../_mock_handler_arguments';
 import { verifyAccessAndContext } from '../../verify_access_and_context';
 import { actionsClientMock } from '../../../actions_client/actions_client.mock';
 

diff --git a/x-pack/plugins/actions/server/routes/connector/list_types/list_types.test.ts b/x-pack/plugins/actions/server/routes/connector/list_types/list_types.test.ts
@@ -8,7 +8,7 @@
 import { httpServiceMock } from '@kbn/core/server/mocks';
 import { LicenseType } from '@kbn/licensing-plugin/server';
 import { licenseStateMock } from '../../../lib/license_state.mock';
-import { mockHandlerArguments } from '../../legacy/_mock_handler_arguments';
+import { mockHandlerArguments } from '../../_mock_handler_arguments';
 import { listTypesRoute } from './list_types';
 import { verifyAccessAndContext } from '../../verify_access_and_context';
 import { actionsClientMock } from '../../../mocks';

diff --git a/x-pack/plugins/actions/server/routes/connector/list_types_system/list_types_system.test.ts b/x-pack/plugins/actions/server/routes/connector/list_types_system/list_types_system.test.ts
@@ -8,7 +8,7 @@
 import { httpServiceMock } from '@kbn/core/server/mocks';
 import { LicenseType } from '@kbn/licensing-plugin/server';
 import { licenseStateMock } from '../../../lib/license_state.mock';
-import { mockHandlerArguments } from '../../legacy/_mock_handler_arguments';
+import { mockHandlerArguments } from '../../_mock_handler_arguments';
 import { listTypesWithSystemRoute } from './list_types_system';
 import { verifyAccessAndContext } from '../../verify_access_and_context';
 import { actionsClientMock } from '../../../mocks';

diff --git a/x-pack/plugins/actions/server/routes/connector/update/update.test.ts b/x-pack/plugins/actions/server/routes/connector/update/update.test.ts
@@ -8,7 +8,7 @@
 import { updateConnectorRoute } from './update';
 import { httpServiceMock } from '@kbn/core/server/mocks';
 import { licenseStateMock } from '../../../lib/license_state.mock';
-import { mockHandlerArguments } from '../../legacy/_mock_handler_arguments';
+import { mockHandlerArguments } from '../../_mock_handler_arguments';
 import { actionsClientMock } from '../../../actions_client/actions_client.mock';
 import { verifyAccessAndContext } from '../../verify_access_and_context';
 import { updateConnectorBodySchema } from '../../../../common/routes/connector/apis/update';

diff --git a/x-pack/plugins/actions/server/routes/get_global_execution_kpi.test.ts b/x-pack/plugins/actions/server/routes/get_global_execution_kpi.test.ts
@@ -7,7 +7,7 @@
 
 import { httpServiceMock } from '@kbn/core/server/mocks';
 import { licenseStateMock } from '../lib/license_state.mock';
-import { mockHandlerArguments } from './legacy/_mock_handler_arguments';
+import { mockHandlerArguments } from './_mock_handler_arguments';
 import { actionsClientMock } from '../actions_client/actions_client.mock';
 import { getGlobalExecutionKPIRoute } from './get_global_execution_kpi';
 import { verifyAccessAndContext } from './verify_access_and_context';

diff --git a/x-pack/plugins/actions/server/routes/get_global_execution_logs.test.ts b/x-pack/plugins/actions/server/routes/get_global_execution_logs.test.ts
@@ -8,7 +8,7 @@
 import { getGlobalExecutionLogRoute } from './get_global_execution_logs';
 import { httpServiceMock } from '@kbn/core/server/mocks';
 import { licenseStateMock } from '../lib/license_state.mock';
-import { mockHandlerArguments } from './legacy/_mock_handler_arguments';
+import { mockHandlerArguments } from './_mock_handler_arguments';
 import { actionsClientMock } from '../actions_client/actions_client.mock';
 import { IExecutionLogResult } from '../../common';
 import { verifyAccessAndContext } from './verify_access_and_context';

diff --git a/x-pack/plugins/actions/server/routes/get_oauth_access_token.test.ts b/x-pack/plugins/actions/server/routes/get_oauth_access_token.test.ts
@@ -8,7 +8,7 @@
 import { getOAuthAccessToken } from './get_oauth_access_token';
 import { httpServiceMock } from '@kbn/core/server/mocks';
 import { licenseStateMock } from '../lib/license_state.mock';
-import { mockHandlerArguments } from './legacy/_mock_handler_arguments';
+import { mockHandlerArguments } from './_mock_handler_arguments';
 import { verifyAccessAndContext } from './verify_access_and_context';
 import { actionsConfigMock } from '../actions_config.mock';
 import { actionsClientMock } from '../actions_client/actions_client.mock';

diff --git a/x-pack/plugins/actions/server/routes/index.ts b/x-pack/plugins/actions/server/routes/index.ts
@@ -19,7 +19,6 @@ import { executeConnectorRoute } from './connector/execute';
 import { getConnectorRoute } from './connector/get';
 import { updateConnectorRoute } from './connector/update';
 import { getOAuthAccessToken } from './get_oauth_access_token';
-import { defineLegacyRoutes } from './legacy';
 import { ActionsConfigurationUtilities } from '../actions_config';
 import { getGlobalExecutionLogRoute } from './get_global_execution_logs';
 import { getGlobalExecutionKPIRoute } from './get_global_execution_kpi';
@@ -32,9 +31,7 @@ export interface RouteOptions {
 }
 
 export function defineRoutes(opts: RouteOptions) {
-  const { router, licenseState, actionsConfigUtils, usageCounter } = opts;
-
-  defineLegacyRoutes(router, licenseState, usageCounter);
+  const { router, licenseState, actionsConfigUtils } = opts;
 
   createConnectorRoute(router, licenseState);
   deleteConnectorRoute(router, licenseState);

diff --git a/x-pack/plugins/actions/server/routes/legacy/create.test.ts b/x-pack/plugins/actions/server/routes/legacy/create.test.ts
diff --git a/x-pack/plugins/actions/server/routes/legacy/create.ts b/x-pack/plugins/actions/server/routes/legacy/create.ts