Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apm: change tail_sampling_storage_limit config default to 0 #12543

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

apm: change tail_sampling_storage_limit config default to 0 #12543

wants to merge 5 commits into from
+8 −3

Conversation

carsonip
Copy link
Member

@carsonip carsonip commented Jan 30, 2025 •
edited
Loading

Proposed commit message

sampling.tail.storage_limit is 0 by default in 9.0. See elastic/apm-server#15467

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@carsonip
apm: remove default tail_sampling_storage_limit
bd9de94 
storage_limit is unset by default in 9.0.
carsonip
carsonip commented Jan 30, 2025
View reviewed changes
Copy link
Member Author

@carsonip carsonip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: is it even possible to publish a 8.18 integration package version in the future?

packages/apm/changelog.yml Outdated Show resolved Hide resolved
packages/apm/manifest.yml Show resolved Hide resolved
packages/apm/manifest.yml Outdated Show resolved Hide resolved
This was referenced Jan 30, 2025
Merged
Open
@mergify mergify bot mentioned this pull request Jan 31, 2025
Merged
2 tasks
@andrewkroh andrewkroh added the Integration:apm Elastic APM label Jan 31, 2025
@carsonip carsonip marked this pull request as ready for review January 31, 2025 17:09
@carsonip carsonip requested a review from a team as a code owner January 31, 2025 17:09
@carsonip carsonip requested a review from simitt January 31, 2025 17:13
@carsonip carsonip changed the title apm: remove default tail_sampling_storage_limit apm: change tail_sampling_storage_limit config default to 0 Jan 31, 2025
@elasticmachine
Copy link

💚 Build Succeeded

History

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simitt simitt Awaiting requested review from simitt

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
breaking change Integration:apm Elastic APM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carsonip @elasticmachine @simitt @andrewkroh