Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jlind23/deprecate loginput #12503

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

Jlind23/deprecate loginput #12503

wants to merge 30 commits into from
+374 −51

Conversation

jlind23
Copy link
Contributor

@jlind23 jlind23 commented Jan 28, 2025 •
edited
Loading

With the introduction of elastic/beats#42295 the log input will soon not be able to run anymore as it is deprecated. To continue running we need to add this allow deprecated parameter to all log input template.

@jlind23 jlind23 self-assigned this Jan 28, 2025
@jlind23 jlind23 marked this pull request as ready for review January 28, 2025 20:15
@jlind23 jlind23 requested review from a team as code owners January 28, 2025 20:15
@jlind23
Copy link
Contributor Author

jlind23 commented Jan 28, 2025

@rdner @cmacknz I'd love to get a sanity check on this 😅

@andrewkroh andrewkroh added Integration:azure_app_service Azure App Service Integration:thycotic_ss Thycotic Secret Server Integration:santa Google Santa Integration:auditd Auditd Logs Integration:infoblox_nios Infoblox NIOS Integration:microsoft_sqlserver Microsoft SQL Server Integration:kibana Kibana Integration:postgresql PostgreSQL Integration:suricata Suricata Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] Team:Stack Monitoring Stack Monitoring team [elastic/stack-monitoring] Team:Security-Linux Platform Linux Platform Security team [elastic/sec-linux-platform] Team:obs-ds-hosted-services Label for the Observability Hosted Services team [elastic/obs-ds-hosted-services] labels Jan 30, 2025
@jlind23 jlind23 requested review from efd6 and rdner January 31, 2025 06:13
@jlind23
Copy link
Contributor Author

jlind23 commented Jan 31, 2025

Thanks @efd6 for the review, I have updated the two packages you pointed out.

efd6
efd6 approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For security-service-integrations.

ishleenk17
ishleenk17 reviewed Jan 31, 2025
View reviewed changes
packages/iis/changelog.yml
@@ -1,6 +1,9 @@
# newer versions go on top
- version: "1.21.1-next"
- version: "1.22.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muthu-mps : Is it ok if we are upgrading the version here like this for IIS.
I am not sure why we had next. If yes, would we want to have 1.21.1 first and then this changelog ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another thread about this in #12503 (comment).

Copy link
Contributor

@muthu-mps muthu-mps Jan 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • As new fields added to the datastream which exists in 8.17.x we did this change. As per the comment here the stack upgrade is not necessary for this change.
  • Its okay to upgrade the version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muthu-mps if you are good with it would you mind approving this PR?

muthu-mps
muthu-mps reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add changelog entry for this change,
packages/mongodb/data_stream/log/agent/stream/log.yml.hbs

muthu-mps
muthu-mps approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comment on changelog entry otherwise,
LGTM!

@jlind23
Copy link
Contributor Author

jlind23 commented Jan 31, 2025

@muthu-mps just updated mongodb changelog and manifest.

@elasticmachine
Copy link

elasticmachine commented Jan 31, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @jlind23

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
85.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishleenk17 ishleenk17 ishleenk17 left review comments

@jsoriano jsoriano jsoriano left review comments

@muthu-mps muthu-mps muthu-mps approved these changes

@taylor-swanson taylor-swanson taylor-swanson approved these changes

@efd6 efd6 efd6 approved these changes

@cmacknz cmacknz cmacknz approved these changes

@consulthys consulthys consulthys approved these changes

@rdner rdner Awaiting requested review from rdner

At least 1 approving review is required to merge this pull request.

Assignees

@jlind23 jlind23

Labels
Integration:activemq ActiveMQ Integration:apache Apache HTTP Server Integration:auditd Auditd Logs Integration:aws AWS Integration:azure_app_service Azure App Service Integration:azure Azure Logs Integration:carbonblack_edr VMware Carbon Black EDR Integration:cassandra Cassandra Integration:cef Common Event Format (CEF) Integration:checkpoint Check Point Integration:crowdstrike CrowdStrike Integration:cyberarkpas CyberArk Privileged Access Security Integration:elasticsearch Elasticsearch Integration:f5_bigip F5 BIG-IP Integration:forcepoint_web Forcepoint Web Security Integration:fortinet_fortiedr Fortinet FortiEDR Logs Integration:fortinet_fortigate Fortinet FortiGate Firewall Logs Integration:haproxy HAProxy Integration:ibmmq IBM MQ Integration:iis IIS Integration:infoblox_nios Infoblox NIOS Integration:iptables Iptables Integration:kafka Kafka Integration:kibana Kibana Integration:logstash Logstash Integration:microsoft_defender_endpoint Microsoft Defender for Endpoint Integration:microsoft_exchange_online_message_trac Microsoft Exchange Online Message Trace Integration:microsoft_sqlserver Microsoft SQL Server Integration:mongodb MongoDB Integration:nats NATS Integration:osquery Osquery Logs Integration:platform_observability Platform Observability Integration:postgresql PostgreSQL Integration:pps Pleasant Password Server Integration:rabbitmq RabbitMQ Logs and Metrics Integration:santa Google Santa Integration:snort Snort Integration:sophos Sophos Integration:stan STAN Integration:suricata Suricata Integration:system System Integration:thycotic_ss Thycotic Secret Server Integration:traefik Traefik Integration:zeek Zeek Team:obs-ds-hosted-services Label for the Observability Hosted Services team [elastic/obs-ds-hosted-services] Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] Team:Security-Linux Platform Linux Platform Security team [elastic/sec-linux-platform] Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] Team:Stack Monitoring Stack Monitoring team [elastic/stack-monitoring]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.