Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include user_agent.version in dynamic_fields (pipeline tests) #12033

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
dynamic_fields:
event.ingested: ".*"
# This can be removed after ES 8.16.2 is the latest minimum version
# Once removed, it requires to update pipeline tests to remove the trailing dot where required.
# Relates: https://github.com/elastic/elasticsearch/pull/117213
"user_agent.version": '^\d+\.\d+(\.|\..*)?$'
kcreddy marked this conversation as resolved.
Show resolved Hide resolved
fields:
"@timestamp": "2020-04-28T11:07:58.223Z"
tags:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,2 +1,6 @@
dynamic_fields:
"event.ingested": ".*"
# This can be removed after ES 8.16.2 is the latest minimum version
# Once removed, it requires to update pipeline tests to remove the trailing dot where required.
# Relates: https://github.com/elastic/elasticsearch/pull/117213
"user_agent.version": '^\d+\.\d+(\.|\..*)?$'
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
dynamic_fields:
# This can be removed after ES 8.16.2 is the latest minimum version
# Once removed, it requires to update pipeline tests to remove the trailing dot where required.
# Relates: https://github.com/elastic/elasticsearch/pull/117213
"user_agent.version": '^\d+\.\d+(\.|\..*)?$'
fields:
# Simulate @timestamp value from Filebeat.
'@timestamp': '2021-11-11T01:02:03.123456789Z'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
dynamic_fields:
# This can be removed after ES 8.16.2 is the latest minimum version
# Once removed, it requires to update pipeline tests to remove the trailing dot where required.
# Relates: https://github.com/elastic/elasticsearch/pull/117213
"user_agent.version": '^(\d+\.\d+(\.|\..*)?|\d+)$'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is pipeline test where user_agent.version contains the value 2016 too.
Same happens in iis package.

fields:
tags:
- preserve_original_event
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
dynamic_fields:
# This can be removed after ES 8.16.2 is the latest minimum version
# Once removed, it requires to update pipeline tests to remove the trailing dot where required.
# Relates: https://github.com/elastic/elasticsearch/pull/117213
"user_agent.version": '^\d+\.\d+(\.|\..*)?$'
fields:
tags:
- forwarded
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
dynamic_fields:
# This can be removed after ES 8.16.2 is the latest minimum version
# Once removed, it requires to update pipeline tests to remove the trailing dot where required.
# Relates: https://github.com/elastic/elasticsearch/pull/117213
"user_agent.version": '^\d+\.\d+(\.|\..*)?$'
fields:
tags:
- preserve_original_event
Original file line number Diff line number Diff line change
@@ -1,2 +1,7 @@
dynamic_fields:
# This can be removed after ES 8.16.2 is the latest minimum version
# Once removed, it requires to update pipeline tests to remove the trailing dot where required.
# Relates: https://github.com/elastic/elasticsearch/pull/117213
"user_agent.version": '^\d+\.\d+(\.|\..*)?$'
numeric_keyword_fields:
- "forgerock.response.detail.active"
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
dynamic_fields:
# This can be removed after ES 8.16.2 is the latest minimum version
# Once removed, it requires to update pipeline tests to remove the trailing dot where required.
# Relates: https://github.com/elastic/elasticsearch/pull/117213
"user_agent.version": '^\d+\.\d+(\.|\..*)?$'

Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
dynamic_fields:
# This can be removed after ES 8.16.2 is the latest minimum version
# Once removed, it requires to update pipeline tests to remove the trailing dot where required.
# Relates: https://github.com/elastic/elasticsearch/pull/117213
"user_agent.version": '^\d+\.\d+(\.|\..*)?$'
fields:
tags:
- preserve_original_event
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,7 @@ fields:
- preserve_original_event
dynamic_fields:
"event.ingested": "^.*$"
# This can be removed after ES 8.16.2 is the latest minimum version
# Once removed, it requires to update pipeline tests to remove the trailing dot where required.
# Relates: https://github.com/elastic/elasticsearch/pull/117213
"user_agent.version": '^\d+\.\d+(\.|\..*)?$'
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
dynamic_fields:
# This can be removed after ES 8.16.2 is the latest minimum version
# Once removed, it requires to update pipeline tests to remove the trailing dot where required.
# Relates: https://github.com/elastic/elasticsearch/pull/117213
"user_agent.version": '^(\d+\.\d+(\.|\..*)?|\d+)$'
fields:
tags:
- preserve_original_event
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,7 @@ dynamic_fields:
# This can be removed after ES 8.14 is the minimum version.
# Relates: https://github.com/elastic/elasticsearch/pull/105689
url.extension: '^.*$'
# This can be removed after ES 8.16.2 is the latest minimum version
# Once removed, it requires to update pipeline tests to remove the trailing dot where required.
# Relates: https://github.com/elastic/elasticsearch/pull/117213
"user_agent.version": '^\d+\.\d+(\.|\..*)?$'
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
dynamic_fields:
# This can be removed after ES 8.16.2 is the latest minimum version
# Once removed, it requires to update pipeline tests to remove the trailing dot where required.
# Relates: https://github.com/elastic/elasticsearch/pull/117213
"user_agent.version": '^\d+\.\d+(\.|\..*)?$'
fields:
tags:
- preserve_original_event
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,7 @@ dynamic_fields:
# This can be removed after ES 8.14 is the minimum version.
# Relates: https://github.com/elastic/elasticsearch/pull/105689
netskope.events.url.extension: '^.*$'
# This can be removed after ES 8.16.2 is the latest minimum version
# Once removed, it requires to update pipeline tests to remove the trailing dot where required.
# Relates: https://github.com/elastic/elasticsearch/pull/117213
"user_agent.version": '^\d+\.\d+(\.|\..*)?$'
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
dynamic_fields:
"event.ingested": ".*"
# This can be removed after ES 8.16.2 is the latest minimum version
# Once removed, it requires to update pipeline tests to remove the trailing dot where required.
# Relates: https://github.com/elastic/elasticsearch/pull/117213
"user_agent.version": '^\d+\.\d+(\.|\..*)?$'
multiline:
first_line_pattern: "^(?:[0-9]{1,3}\\.){3}[0-9]{1,3}"
fields:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
dynamic_fields:
# This can be removed after ES 8.16.2 is the latest minimum version
# Once removed, it requires to update pipeline tests to remove the trailing dot where required.
# Relates: https://github.com/elastic/elasticsearch/pull/117213
"user_agent.version": '^\d+\.\d+(\.|\..*)?$'
multiline:
first_line_pattern: "^(?:[0-9]{1,3}\\.){3}[0-9]{1,3}"
fields:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
dynamic_fields:
# This can be removed after ES 8.16.2 is the latest minimum version
# Once removed, it requires to update pipeline tests to remove the trailing dot where required.
# Relates: https://github.com/elastic/elasticsearch/pull/117213
"user_agent.version": '^\d+\.\d+(\.|\..*)?$'
fields:
"@timestamp": "2020-04-28T11:07:58.223Z"
"_conf":
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
dynamic_fields:
# This can be removed after ES 8.16.2 is the latest minimum version
# Once removed, it requires to update pipeline tests to remove the trailing dot where required.
# Relates: https://github.com/elastic/elasticsearch/pull/117213
"user_agent.version": '^\d+\.\d+(\.|\..*)?$'
fields:
"@timestamp": "2020-04-28T11:07:58.223Z"
tags:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
dynamic_fields:
# This can be removed after ES 8.16.2 is the latest minimum version
# Once removed, it requires to update pipeline tests to remove the trailing dot where required.
# Relates: https://github.com/elastic/elasticsearch/pull/117213
"user_agent.version": '^\d+\.\d+(\.|\..*)?$'
fields:
"@timestamp": "2020-04-28T11:07:58.223Z"
tags:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
dynamic_fields:
# This can be removed after ES 8.16.2 is the latest minimum version
# Once removed, it requires to update pipeline tests to remove the trailing dot where required.
# Relates: https://github.com/elastic/elasticsearch/pull/117213
"user_agent.version": '^\d+\.\d+(\.|\..*)?$'
fields:
"@timestamp": "2020-04-28T11:07:58.223Z"
tags:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
dynamic_fields:
# This can be removed after ES 8.16.2 is the latest minimum version
# Once removed, it requires to update pipeline tests to remove the trailing dot where required.
# Relates: https://github.com/elastic/elasticsearch/pull/117213
"user_agent.version": '^\d+\.\d+(\.|\..*)?$'
fields:
tags:
- preserve_original_event
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
dynamic_fields:
# This can be removed after ES 8.16.2 is the latest minimum version
# Once removed, it requires to update pipeline tests to remove the trailing dot where required.
# Relates: https://github.com/elastic/elasticsearch/pull/117213
"user_agent.version": '^\d+\.\d+(\.|\..*)?$'
fields:
tags:
- preserve_original_event
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
dynamic_fields:
# This can be removed after ES 8.16.2 is the latest minimum version
# Once removed, it requires to update pipeline tests to remove the trailing dot where required.
# Relates: https://github.com/elastic/elasticsearch/pull/117213
"user_agent.version": '^\d+\.\d+(\.|\..*)?$'
"network.community_id": ".*"
fields:
tags:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
dynamic_fields:
"event.ingested": ".*"
# This can be removed after ES 8.16.2 is the latest minimum version
# Once removed, it requires to update pipeline tests to remove the trailing dot where required.
# Relates: https://github.com/elastic/elasticsearch/pull/117213
"user_agent.version": '^\d+\.\d+(\.|\..*)?$'
fields:
"@timestamp": "2020-04-28T11:07:58.223Z"
tags:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
dynamic_fields:
# This can be removed after ES 8.16.2 is the latest minimum version
# Once removed, it requires to update pipeline tests to remove the trailing dot where required.
# Relates: https://github.com/elastic/elasticsearch/pull/117213
"user_agent.version": '^\d+\.\d+(\.|\..*)?$'
fields:
tags:
- preserve_original_event
Expand Down