Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #4361) Change CA generation in tests to avoid using SHA1 #4399

Open
wants to merge 1 commit into
base: 8.x
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 30, 2025

What is the problem this PR solves?

Tests ran with GODEBUG=fips140=only will panic due to CA SubjectKeyId generation using SHA1 by default.

How does this PR solve the problem?

Populate SubjectKeyId with value generated by other algorithm; copied implementation from elastic/elastic-agent-libs#263

How to test this PR locally

GODEBUG=fips140=only gotip test ./...

Design Checklist

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
    This is an automatic backport of pull request Change CA generation in tests to avoid using SHA1 #4361 done by Mergify.

@mergify mergify bot requested a review from a team as a code owner January 30, 2025 18:17
@mergify mergify bot added the backport label Jan 30, 2025
@michel-laterman
Copy link
Contributor

buildkite test this

@michel-laterman michel-laterman enabled auto-merge (squash) January 30, 2025 23:01
@pkoutsovasilis
Copy link

buildkite test this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants