Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automation] Bump Golang version to 1.23.4 #4173

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 4, 2024

Bump golang-version to latest version

Update .go-version

1 file(s) updated with "1.23.4": * .go-version

1.23.4
no GitHub Release found for go1.23.4 on "https://github.com/golang/go"
Update .golangci.yml

1 file(s) updated with "1.23.4": * .golangci.yml

1.23.4
no GitHub Release found for go1.23.4 on "https://github.com/golang/go"
GitHub Action workflow link
Updatecli logo

Created automatically by Updatecli

Options:

Most of Updatecli configuration is done via its manifest(s).

  • If you close this pull request, Updatecli will automatically reopen it, the next time it runs.
  • If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.

Feel free to report any issues at github.com/updatecli/updatecli.
If you find this tool useful, do not hesitate to star our GitHub repository as a sign of appreciation, and/or to tell us directly on our chat!

@github-actions github-actions bot requested a review from a team as a code owner December 4, 2024 20:06
@github-actions github-actions bot added the backport-skip Skip notification from the automated backport with mergify label Dec 4, 2024
@jlind23
Copy link
Contributor

jlind23 commented Dec 5, 2024

Build is failing as the golang crossbuild image is missing for now.
@ycombinator I believe this should be backported to 8.x right?

@github-actions github-actions bot force-pushed the updatecli_main_901223529a6beca5c9cb3180f1dae9731c8da4e9c40169d7042cc0163a6d7e24 branch from 54fb14d to 6664758 Compare December 5, 2024 20:06
@jlind23
Copy link
Contributor

jlind23 commented Dec 5, 2024

buildkite test it

@jlind23 jlind23 enabled auto-merge (squash) December 5, 2024 21:05
@jlind23
Copy link
Contributor

jlind23 commented Dec 6, 2024

@elastic/elastic-agent-control-plane seems like Test agent remote ES output failed, is this a known issue?


FAIL: Test_Agent_Remote_ES_Output (9.46s) | 8s
-- | --
  | === RUN   Test_Agent_Remote_ES_Output_ForceUnenroll
  | remote_es_output_integration_test.go:301: Test fleet server port=35059
  | remote_es_output_integration_test.go:304: Create policy with remote ES output
  | remote_es_output_integration_test.go:335: Create API key and enrollment key for new policy
  | remote_es_output_integration_test.go:368: Enroll agent
  | fleet_integration_test.go:727: map[action:created item:map[access_api_key:M2ltdm1KTUJ3T2RKb0kzV25CV3g6MGZMeXUwb1ZSN2l2SGtJN0Y5ZGp0UQ== access_api_key_id:3imvmJMBwOdJoI3WnBWx actions:<nil> active:true enrolled_at:2024-12-05T21:17:46Z id:54923071-0235-4f8a-871d-850c46331ac1 local_metadata:map[] policy_id:9edf2d73-f639-4b1c-a307-91c87378253f status:online tags:[] type:PERMANENT user_provided_metadata:<nil>]]
  | remote_es_output_integration_test.go:40: Fake a checkin for agent 54923071-0235-4f8a-871d-850c46331ac1
  | remote_es_output_integration_test.go:50: Checkin successful, verify body
  | remote_es_output_integration_test.go:110: Fake an ack for action policy:9edf2d73-f639-4b1c-a307-91c87378253f:1 for agent 54923071-0235-4f8a-871d-850c46331ac1
  | remote_es_output_integration_test.go:129: Ack successful, verify body
  | remote_es_output_integration_test.go:388: Force Unenroll agent - set inactive
  | remote_es_output_integration_test.go:398: Checkin so that invalidate logic runs
  | remote_es_output_integration_test.go:402: Fake a checkin for agent 54923071-0235-4f8a-871d-850c46331ac1
  | remote_es_output_integration_test.go:412: Verify that remote API key is invalidated


@github-actions github-actions bot force-pushed the updatecli_main_901223529a6beca5c9cb3180f1dae9731c8da4e9c40169d7042cc0163a6d7e24 branch from 6af1fd7 to 0f0b027 Compare December 6, 2024 20:06
@ycombinator
Copy link
Contributor

ycombinator commented Dec 7, 2024

@elastic/elastic-agent-control-plane seems like Test agent remote ES output failed, is this a known issue?

Yes, this is #4170, which was recently fixed by #4171. Rebasing this PR on main...

@ycombinator ycombinator disabled auto-merge December 7, 2024 05:02
Made with ❤️️ by updatecli
Made with ❤️️ by updatecli
@ycombinator ycombinator force-pushed the updatecli_main_901223529a6beca5c9cb3180f1dae9731c8da4e9c40169d7042cc0163a6d7e24 branch from 07e9cd4 to f55c3bd Compare December 7, 2024 05:04
@ycombinator ycombinator enabled auto-merge (squash) December 7, 2024 05:04
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@ycombinator ycombinator merged commit 961d969 into main Dec 7, 2024
8 checks passed
@ycombinator ycombinator deleted the updatecli_main_901223529a6beca5c9cb3180f1dae9731c8da4e9c40169d7042cc0163a6d7e24 branch December 7, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants