-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated discovery node class - and other ml fixes #3153
base: main
Are you sure you want to change the base?
Conversation
The failure is:
|
my bad, messed up an import, fixing it now |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
@pquentin I just understood the source of my confusion: it seems like DiscoveryNode can be written in 2 ways, one is implemented in
with the id as an upper level json object, while the method
with the id inside the node object. Both ways seem to be accepted and present in the recordings. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
4b86700
to
0ea6aed
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
References for the fixes:
detectors
- DetectorUpdateaggs
as alias foraggregations
, both acceptedignore_throttled
(could not find server proof), body parameter job_iddetectors
uses different class, DetectorUpdateThe only thins missing server-side proof is
ignore_throttled
as query parameter inMlPutJobRequest
, I couldn't find it in parent classes either, so I'm trusting the validation on that one.