Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition in product check #8296

Merged
merged 4 commits into from
Aug 13, 2024
Merged

Fix race condition in product check #8296

merged 4 commits into from
Aug 13, 2024

Conversation

flobernd
Copy link
Member

Fixes a race condition in the product check.

Closes #8268

@flobernd flobernd requested a review from Mpdreamz August 12, 2024 14:53
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Not sure if the

The type or namespace name 'Experimental' does not exist in the namespace 'Elastic.Clients.Elasticsearch' (are you missing an assembly reference?)

are related.

@flobernd
Copy link
Member Author

The tests are not fully updated after the breaking 8.13 release. Have to spend some time on that soon, to have reliable CI builds again.

@flobernd flobernd changed the title Fix product check Fix race condition in product check Aug 13, 2024
@flobernd flobernd merged commit 0433fde into main Aug 13, 2024
5 of 19 checks passed
@flobernd flobernd deleted the fix-product-check branch August 13, 2024 07:09
github-actions bot pushed a commit that referenced this pull request Aug 13, 2024
github-actions bot pushed a commit that referenced this pull request Aug 13, 2024
flobernd added a commit that referenced this pull request Aug 13, 2024
flobernd added a commit that referenced this pull request Aug 13, 2024
flobernd added a commit that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception thrown trying to await requests tasks after multiple SearchAsync are called
2 participants